Skip to content

Commit b7e5833

Browse files
authored
Merge pull request #1386 from topcoder-platform/pm-3254
fix(PM-3254): check for failed submissions instead of passing submission
2 parents 82bd31f + 17502e4 commit b7e5833

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/apps/review/src/lib/components/TableReview/TableReview.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -236,9 +236,9 @@ export const TableReview: FC<TableReviewProps> = (props: TableReviewProps) => {
236236

237237
const filterScreeningPassedReviews = useCallback(
238238
(submissions: SubmissionInfo[]): SubmissionInfo[] => submissions.filter(
239-
submission => props.screeningOutcome.passingSubmissionIds.has(submission.id ?? ''),
239+
submission => !props.screeningOutcome.failingSubmissionIds.has(submission.id ?? ''),
240240
),
241-
[props.screeningOutcome.passingSubmissionIds],
241+
[props.screeningOutcome.failingSubmissionIds],
242242
)
243243

244244
const submissionsForAggregation = useMemo<SubmissionInfo[]>(

0 commit comments

Comments
 (0)