Skip to content

Commit 21226f2

Browse files
committed
fix: repond to appeals
1 parent 1b0df87 commit 21226f2

File tree

2 files changed

+10
-3
lines changed

2 files changed

+10
-3
lines changed

.circleci/config.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -226,6 +226,7 @@ workflows:
226226
branches:
227227
only:
228228
- dev
229+
- pm-3141_3
229230

230231
- deployQa:
231232
context: org-global

src/apps/review/src/pages/reviews/components/ReviewViewer/ReviewViewer.tsx

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,11 +23,13 @@ import { useReviewsContext } from '../../ReviewsContext'
2323

2424
import { ReviewScorecardHeader } from './ReviewScorecardHeader'
2525
import styles from './ReviewViewer.module.scss'
26+
import { set } from 'lodash'
2627

2728
const ReviewViewer: FC = () => {
2829
const navigate = useAppNavigate()
2930
const [searchParams] = useSearchParams()
3031
const [respondToAppeals, setRespondToAppeals] = useState(searchParams.get('respondToAppeals') === 'true')
32+
const [initialLoad, setInitialLoad] = useState(false)
3133
const {
3234
reviewId,
3335
setReviewStatus,
@@ -208,11 +210,15 @@ const ReviewViewer: FC = () => {
208210
useEffect(() => {
209211
if (!canEditScorecard && isManagerEdit) {
210212
setIsManagerEdit(false)
211-
} else if (!isManagerEdit && respondToAppeals) {
213+
}
214+
}, [canEditScorecard, isManagerEdit])
215+
216+
useEffect(() => {
217+
if (!initialLoad && respondToAppeals) {
212218
setIsManagerEdit(true)
213-
setRespondToAppeals(false)
219+
setInitialLoad(true)
214220
}
215-
}, [canEditScorecard, isManagerEdit, respondToAppeals])
221+
}, [isManagerEdit, respondToAppeals, initialLoad])
216222

217223
const toggleManagerEdit = useCallback(() => {
218224
setIsManagerEdit(prev => !prev)

0 commit comments

Comments
 (0)