clean up

Author: ThomasKranitsas

src/common/helper.js

@@ -864,20 +864,17 @@ async function ensureAccessibleByGroupsAccess (currentUser, challenge) {
  */
 async function _ensureAccessibleForTaskChallenge (currentUser, challenge) {
   let challengeResourceIds
-  // Remove privateDescription for unregistered users
   if (currentUser) {
     if (!currentUser.isMachine) {
       const challengeResources = await getChallengeResources(challenge.id)
       challengeResourceIds = _.map(challengeResources, r => _.toString(r.memberId))
-      if (!_.includes(challengeResourceIds, _.toString(currentUser.userId))) {
-      }
     }
   }
   // Check if challenge is task and apply security rules
   if (_.get(challenge, 'task.isTask', false) && _.get(challenge, 'task.isAssigned', false)) {
-    const canAccesChallenge = _.isUndefined(currentUser) ? false : _.includes((challengeResourceIds || []), _.toString(currentUser.userId)) || currentUser.isMachine || hasAdminRole(currentUser)
+    const canAccesChallenge = _.isUndefined(currentUser) ? false : currentUser.isMachine || hasAdminRole(currentUser) || _.includes((challengeResourceIds || []), _.toString(currentUser.userId))
     if (!canAccesChallenge) {
-      throw new errors.ForbiddenError(`You don't have access to view this task as you don't have a resource on it`)
+      throw new errors.ForbiddenError(`You don't have access to view this challenge`)
     }
   }
 }