split setting copilot payment into 2 phases

Author: ThomasKranitsas

src/services/ProcessorService.js

@@ -202,6 +202,9 @@ async function setCopilotPayment (challengeId, legacyChallengeId, prizeSets = []
         return
       }
       logger.debug(`Setting Copilot Payment: ${copilotPayment} for legacyId ${legacyChallengeId} for copilot ${copilotResource.memberId}`)
+      if (copilotPayment !== null && copilotPayment >= 0) {
+        await copilotPaymentService.setManualCopilotPayment(legacyChallengeId, createdBy, updatedBy)
+      }
       await copilotPaymentService.setCopilotPayment(legacyChallengeId, copilotPayment, createdBy, updatedBy)
     }
   } catch (e) {

src/services/copilotPaymentService.js

@@ -50,27 +50,49 @@ async function prepare (connection, sql) {
 }
 
 /**
- * Set the copilot payment
+ * Set manual copilot payment
  * @param {Number} challengeLegacyId the legacy challenge ID
- * @param {Number} amount the $ amount of the copilot payment
  * @param {String} createdBy the create user handle
  * @param {String} updatedBy the update user handle
  */
-async function setCopilotPayment (challengeLegacyId, amount, createdBy, updatedBy) {
+async function setManualCopilotPayment (challengeLegacyId, createdBy, updatedBy) {
   const connection = await helper.getInformixConnection()
   try {
     await connection.beginTransactionAsync()
     const copilotResourceId = await getCopilotResourceId(connection, challengeLegacyId)
-    const copilotPayment = await getCopilotPayment(connection, challengeLegacyId)
-    if (amount != null && amount >= 0) {
+    if (copilotResourceId) {
       // Make sure the payment type is set to manual
-      // TODO: Figure out why data is not saved in IFX even when there are no errors
       const paymentType = await getCopilotPaymentType(connection, copilotResourceId)
       if (!paymentType) {
         await createCopilotPaymentType(connection, copilotResourceId, 'true', updatedBy || createdBy)
       } else if (_.toLower(_.toString(paymentType.value)) !== 'true') {
         await updateCopilotPaymentType(connection, copilotResourceId, 'true', updatedBy || createdBy)
       }
+    }
+    await connection.commitTransactionAsync()
+  } catch (e) {
+    logger.error(`Error in 'setManualCopilotPayment' ${e}`)
+    await connection.rollbackTransactionAsync()
+    throw e
+  } finally {
+    await connection.closeAsync()
+  }
+}
+
+/**
+ * Set the copilot payment
+ * @param {Number} challengeLegacyId the legacy challenge ID
+ * @param {Number} amount the $ amount of the copilot payment
+ * @param {String} createdBy the create user handle
+ * @param {String} updatedBy the update user handle
+ */
+async function setCopilotPayment (challengeLegacyId, amount, createdBy, updatedBy) {
+  const connection = await helper.getInformixConnection()
+  try {
+    await connection.beginTransactionAsync()
+    const copilotResourceId = await getCopilotResourceId(connection, challengeLegacyId)
+    const copilotPayment = await getCopilotPayment(connection, challengeLegacyId)
+    if (amount !== null && amount >= 0) {
       if (copilotPayment) {
         logger.debug(`Copilot payment exists, updating: ${challengeLegacyId}`)
         await updateCopilotPayment(connection, copilotResourceId, challengeLegacyId, amount, updatedBy)
@@ -194,5 +216,6 @@ async function deleteCopilotPayment (connection, challengeLegacyId) {
 }
 
 module.exports = {
+  setManualCopilotPayment,
   setCopilotPayment
 }