Still process ifx operation on newly created challenges

Author: ThomasKranitsas

src/services/ProcessorService.js

@@ -493,7 +493,7 @@ async function processUpdate (message) {
     return
   } else if (!message.payload.legacyId) {
     logger.debug('Legacy ID does not exist. Will create...')
-    return processCreate(message)
+    await processCreate(message)
   }
   const m2mToken = await helper.getM2MToken()
 
@@ -534,14 +534,16 @@ async function processUpdate (message) {
   // logger.debug('Parsed Payload', saveDraftContestDTO)
   try {
     try {
-      await helper.putRequest(`${config.V4_CHALLENGE_API_URL}/${message.payload.legacyId}`, { param: _.omit(saveDraftContestDTO, ['groupsToBeAdded', 'groupsToBeDeleted']) }, m2mToken)
+      if (challenge) {
+        await helper.putRequest(`${config.V4_CHALLENGE_API_URL}/${message.payload.legacyId}`, { param: _.omit(saveDraftContestDTO, ['groupsToBeAdded', 'groupsToBeDeleted']) }, m2mToken)
+      }
     } catch (e) {
       logger.warn('Failed to update the challenge via the V4 API')
       logger.error(e)
     }
     await associateChallengeGroups(saveDraftContestDTO.groupsToBeAdded, saveDraftContestDTO.groupsToBeDeleted, message.payload.legacyId)
-    await associateChallengeTerms(message.payload.terms, message.payload.legacyId, _.get(message, 'payload.createdBy'), _.get(message, 'payload.updatedBy'))
-    await setCopilotPayment(message.payload.id, message.payload.legacyId, _.get(message, 'payload.prizeSets'), _.get(message, 'payload.createdBy'), _.get(message, 'payload.updatedBy'), m2mToken)
+    await associateChallengeTerms(message.payload.terms, message.payload.legacyId, _.get(message, 'payload.createdBy'), _.get(message, 'payload.updatedBy') || _.get(message, 'payload.createdBy'))
+    await setCopilotPayment(message.payload.id, message.payload.legacyId, _.get(message, 'payload.prizeSets'), _.get(message, 'payload.createdBy'), _.get(message, 'payload.updatedBy') || _.get(message, 'payload.createdBy'), m2mToken)
 
     // Update metadata in IFX
     if (message.payload.metadata && message.payload.metadata.length > 0) {
@@ -569,7 +571,7 @@ async function processUpdate (message) {
         }
       }
     }
-    if (message.payload.status) {
+    if (message.payload.status && challenge) {
       // logger.info(`The status has changed from ${challenge.currentStatus} to ${message.payload.status}`)
       if (message.payload.status === constants.challengeStatuses.Active && challenge.currentStatus !== constants.challengeStatuses.Active) {
         logger.info('Activating challenge...')
@@ -590,7 +592,11 @@ async function processUpdate (message) {
         }
       }
     }
-    await helper.forceV4ESFeeder(message.payload.legacyId)
+    try {
+      await helper.forceV4ESFeeder(message.payload.legacyId)
+    } catch (e) {
+      logger.warn('Failed to call V4 ES Feeder')
+    }
   } catch (e) {
     logger.error('processUpdate Catch', e)
     throw e