ALl meta should be strings

Author: ThomasKranitsas

src/utils/metadataExtractor.js

@@ -16,7 +16,7 @@ const getMeta = (metadata = [], key) => _.find(metadata, meta => meta.name === k
  * @param {Any} defaultValue the default value
  */
 function extractBillingProject (challenge, defaultValue) {
-  return _.get(challenge, 'billingAccountId', _.get(challenge, 'billing.billingAccountId', defaultValue))
+  return _.get(challenge, 'billingAccountId', _.get(challenge, 'billing.billingAccountId', _.toString(defaultValue)))
 }
 
 /**
@@ -26,7 +26,7 @@ function extractBillingProject (challenge, defaultValue) {
  */
 function extractSubmissionLimit (challenge, defaultValue) {
   const entry = getMeta(challenge.metadata, 'submissionLimit')
-  if (!entry) return defaultValue
+  if (!entry) return _.toString(defaultValue)
   try {
     const parsedEntryValue = JSON.parse(entry.value)
     if (parsedEntryValue.limit) {
@@ -37,7 +37,7 @@ function extractSubmissionLimit (challenge, defaultValue) {
   } catch (e) {
     entry.value = null
   }
-  return entry.value || defaultValue
+  return _.toString(entry.value || defaultValue)
 }
 
 /**
@@ -46,7 +46,7 @@ function extractSubmissionLimit (challenge, defaultValue) {
  * @param {Any} defaultValue the default value
  */
 function extractSpecReviewCost (challenge, defaultValue) {
-  return _.get(_.find(_.get(challenge, 'prizeSets', []), p => p.type === 'specReviewer') || {}, 'prizes[0].value', defaultValue)
+  return _.get(_.find(_.get(challenge, 'prizeSets', []), p => p.type === 'specReviewer') || {}, 'prizes[0].value', _.toString(defaultValue))
 }
 
 /**
@@ -56,8 +56,8 @@ function extractSpecReviewCost (challenge, defaultValue) {
  */
 function extractDrPoints (challenge, defaultValue) {
   const entry = getMeta(challenge.metadata, 'drPoints')
-  if (!entry) return defaultValue
-  return entry.value || defaultValue
+  if (!entry) return _.toString(defaultValue)
+  return _.toString(entry.value || defaultValue)
 }
 
 /**
@@ -67,7 +67,7 @@ function extractDrPoints (challenge, defaultValue) {
  */
 function extractApprovalRequired (challenge, defaultValue) {
   const entry = getMeta(challenge.metadata, 'approvalRequired')
-  if (!entry) return defaultValue
+  if (!entry) return _.toString(defaultValue)
   return _.toString(entry.value)
 }
 
@@ -78,7 +78,7 @@ function extractApprovalRequired (challenge, defaultValue) {
  */
 function extractPostMortemRequired (challenge, defaultValue) {
   const entry = getMeta(challenge.metadata, 'postMortemRequired')
-  if (!entry) return defaultValue
+  if (!entry) return _.toString(defaultValue)
   return _.toString(entry.value)
 }
 
@@ -89,7 +89,7 @@ function extractPostMortemRequired (challenge, defaultValue) {
  */
 function extractTrackLateDeliverablesRequired (challenge, defaultValue) {
   const entry = getMeta(challenge.metadata, 'trackLateDeliverables')
-  if (!entry) return defaultValue
+  if (!entry) return _.toString(defaultValue)
   return _.toString(entry.value)
 }
 
@@ -100,7 +100,7 @@ function extractTrackLateDeliverablesRequired (challenge, defaultValue) {
  */
 function extractAllowStockArtRequired (challenge, defaultValue) {
   const entry = getMeta(challenge.metadata, 'allowStockArt')
-  if (!entry) return defaultValue
+  if (!entry) return _.toString(defaultValue)
   return _.toString(entry.value)
 }
 
@@ -111,7 +111,7 @@ function extractAllowStockArtRequired (challenge, defaultValue) {
  */
 function extractSubmissionViewable (challenge, defaultValue) {
   const entry = getMeta(challenge.metadata, 'submissionViewable')
-  if (!entry) return defaultValue
+  if (!entry) return _.toString(defaultValue)
   return _.toString(entry.value)
 }
 
@@ -122,7 +122,7 @@ function extractSubmissionViewable (challenge, defaultValue) {
  */
 function extractReviewFeedback (challenge, defaultValue) {
   const entry = getMeta(challenge.metadata, 'reviewFeedback')
-  if (!entry) return defaultValue
+  if (!entry) return _.toString(defaultValue)
   return _.toString(entry.value)
 }
 
@@ -133,8 +133,8 @@ function extractReviewFeedback (challenge, defaultValue) {
  */
 function extractEnvironment (challenge, defaultValue) {
   const entry = getMeta(challenge.metadata, 'environment')
-  if (!entry) return defaultValue
-  return entry.value
+  if (!entry) return _.toString(defaultValue)
+  return _.toString(entry.value)
 }
 
 /**
@@ -144,8 +144,8 @@ function extractEnvironment (challenge, defaultValue) {
  */
 function extractCodeRepo (challenge, defaultValue) {
   const entry = getMeta(challenge.metadata, 'codeRepo')
-  if (!entry) return defaultValue
-  return entry.value
+  if (!entry) return _.toString(defaultValue)
+  return _.toString(entry.value)
 }
 
 /**
@@ -155,7 +155,7 @@ function extractCodeRepo (challenge, defaultValue) {
  */
 function extractEstimateEffortHours (challenge, defaultValue) {
   const entry = getMeta(challenge.metadata, 'effortHoursEstimate')
-  if (!entry) return defaultValue
+  if (!entry) return _.toString(defaultValue)
   return _.toNumber(entry.value)
 }
 
@@ -166,7 +166,7 @@ function extractEstimateEffortHours (challenge, defaultValue) {
  */
 function extractEstimateEffortOffshore (challenge, defaultValue) {
   const entry = getMeta(challenge.metadata, 'effortHoursOffshore')
-  if (!entry) return defaultValue
+  if (!entry) return _.toString(defaultValue)
   return _.toNumber(entry.value)
 }
 
@@ -177,7 +177,7 @@ function extractEstimateEffortOffshore (challenge, defaultValue) {
  */
 function extractEstimateEffortOnsite (challenge, defaultValue) {
   const entry = getMeta(challenge.metadata, 'effortHoursOnshore')
-  if (!entry) return defaultValue
+  if (!entry) return _.toString(defaultValue)
   return _.toNumber(entry.value)
 }