fixes

Author: ThomasKranitsas

src/constants.js

@@ -7,8 +7,7 @@ const prizeSetTypes = {
   ChallengePrizes: 'placement',
   CopilotPayment: 'copilot',
   ReviewerPayment: 'reviewer',
-  CheckPoint: 'checkpoint',
-  SpecReview: 'specReviewer'
+  CheckPoint: 'checkpoint'
 }
 
 const EVENT_ORIGINATOR = 'legacy-challenge-processor'

src/services/ProcessorService.js

@@ -691,14 +691,14 @@ async function processUpdate (message) {
   try {
     // extract metadata from challenge and insert into IFX
     for (const metadataKey of _.keys(constants.supportedMetadata)) {
-      const metaValue = constants.supportedMetadata[metadataKey].method(message.payload, constants.supportedMetadata[metadataKey].defaultValue)
-      if (metaValue !== null) {
-        try {
+      try {
+        const metaValue = constants.supportedMetadata[metadataKey].method(message.payload, constants.supportedMetadata[metadataKey].defaultValue)
+        if (metaValue !== null) {
           logger.info(`Setting ${constants.supportedMetadata[metadataKey].description} to ${metaValue}`)
           await metadataService.createOrUpdateMetadata(legacyId, metadataKey, metaValue, _.get(message, 'payload.updatedBy') || _.get(message, 'payload.createdBy'))
-        } catch (e) {
-          logger.warn(`Failed to set ${constants.supportedMetadata[metadataKey].description} to ${metaValue}`)
         }
+      } catch (e) {
+        logger.warn(`Failed to set ${constants.supportedMetadata[metadataKey].description} to ${metaValue}`)
       }
     }
     // Thomas - get rid of this and add required info directly via IFX

src/utils/metadataExtractor.js

@@ -2,7 +2,6 @@
  * Metadata extractor
  */
 const _ = require('lodash')
-const constants = require('../constants')
 
 /**
  * Get metadata entry by key
@@ -53,7 +52,7 @@ function extractSubmissionLimit (challenge, defaultValue) {
  * @param {Any} defaultValue the default value
  */
 function extractSpecReviewCost (challenge, defaultValue) {
-  return _.get(_.find(_.get(challenge, 'prizeSets', []), p => p.type === constants.prizeSetTypes.SpecReview) || {}, 'prizes[0].value', defaultValue)
+  return _.get(_.find(_.get(challenge, 'prizeSets', []), p => p.type === 'specReviewer') || {}, 'prizes[0].value', defaultValue)
 }
 
 /**