Replace message payload with data from the challenge API

Author: ThomasKranitsas

src/app.js

@@ -3,6 +3,7 @@
  */
 
 require('./bootstrap')
+const _ = require('lodash')
 const config = require('config')
 const Kafka = require('no-kafka')
 const healthcheck = require('@topcoder-platform/topcoder-healthcheck-dropin')
@@ -45,6 +46,21 @@ const dataHandler = (messageSet, topic, partition) => Promise.each(messageSet, a
     return
   }
 
+  // do not trust the message payload
+  // the message.payload will be replaced with the data from the API
+  try {
+    const challengeUuid = _.get(messageJSON, 'payload.id')
+    if (_.isEmpty(challengeUuid)) {
+      throw new Error('Invalid payload')
+    }
+    const m2mToken = await helper.getM2MToken()
+    const v5Challenge = await helper.getRequest(`${config.V5_CHALLENGE_API_URL}/${challengeUuid}`, m2mToken)
+    messageJSON.payload = v5Challenge.body
+  } catch (err) {
+    logger.debug('Failed to fetch challenge information')
+    logger.logFullError(err)
+  }
+
   try {
     if (topic === config.CREATE_CHALLENGE_TOPIC) {
       await ProcessorService.processCreate(messageJSON)

src/services/ProcessorService.js

@@ -443,9 +443,7 @@ async function processUpdate (message) {
         logger.info('Activated!')
       }
       if (message.payload.status === constants.challengeStatuses.Completed && challenge.currentStatus !== constants.challengeStatuses.Completed) {
-        const challengeUuid = message.payload.id
-        const v5Challenge = await helper.getRequest(`${config.V5_CHALLENGE_API_URL}/${challengeUuid}`, m2mToken)
-        if (v5Challenge.body.task.isTask) {
+        if (message.payload.task.isTask) {
           logger.info('Challenge is a TASK')
           if (!message.payload.winners || message.payload.winners.length === 0) {
             throw new Error('Cannot close challenge without winners')