set number of reviewers on self service challenges

Author: ThomasKranitsas

src/services/ProcessorService.js

@@ -16,6 +16,7 @@ const copilotPaymentService = require('./copilotPaymentService')
 const timelineService = require('./timelineService')
 const metadataService = require('./metadataService')
 const paymentService = require('./paymentService')
+const { createOrSetNumberOfReviewers } = require('./selfServiceReviewerService')
 
 /**
  * Drop and recreate phases in ifx
@@ -68,8 +69,10 @@ async function recreatePhases (legacyId, v5Phases, createdBy) {
  * Sync the information from the v5 phases into legacy
  * @param {Number} legacyId the legacy challenge ID
  * @param {Array} v5Phases the v5 phases
+ * @param {Boolean} isSelfService is the challenge self-service
+ * @param {String} createdBy the created by
  */
-async function syncChallengePhases (legacyId, v5Phases) {
+async function syncChallengePhases (legacyId, v5Phases, createdBy, isSelfService) {
   const phaseTypes = await timelineService.getPhaseTypes()
   const phasesFromIFx = await timelineService.getChallengePhases(legacyId)
   logger.debug(`Phases from v5: ${JSON.stringify(v5Phases)}`)
@@ -104,6 +107,10 @@ async function syncChallengePhases (legacyId, v5Phases) {
     } else {
       logger.info(`No v5 Equivalent Found for ${phaseName}`)
     }
+    if (isSelfService && phaseName === 'Review') {
+      // make sure to set the required reviewers to 2
+      await createOrSetNumberOfReviewers(phase.project_phase_id, 2, createdBy)
+    }
   }
   // TODO: What about iterative reviews? There can be many for the same challenge.
   // TODO: handle timeline template updates
@@ -695,7 +702,7 @@ async function processMessage (message) {
     }
 
     if (!_.get(message.payload, 'task.isTask')) {
-      await syncChallengePhases(legacyId, message.payload.phases)
+      await syncChallengePhases(legacyId, message.payload.phases, _.get(message, 'payload.legacy.selfService'), createdByUserId)
     } else {
       logger.info('Will skip syncing phases as the challenge is a task...')
     }
@@ -721,7 +728,8 @@ processMessage.schema = {
         reviewType: Joi.string().required(),
         confidentialityType: Joi.string(),
         directProjectId: Joi.number(),
-        forumId: Joi.number().integer().positive()
+        forumId: Joi.number().integer().positive(),
+        selfService: Joi.boolean()
       }).unknown(true),
       task: Joi.object().keys({
         isTask: Joi.boolean().default(false),

src/services/selfServiceReviewerService.js

@@ -0,0 +1,84 @@
+/**
+ * Number of reviewers Service
+ * Interacts with InformixDB
+ */
+const util = require('util')
+const logger = require('../common/logger')
+const helper = require('../common/helper')
+
+const QUERY_GET_ENTRY = 'SELECT parameter FROM phase_criteria WHERE project_phase_id = %d'
+const QUERY_CREATE = 'INSERT INTO phase_criteria (project_phase_id, phase_criteria_type_id, parameter, create_user, create_date, modify_user, modify_date) VALUES (?, 6, ?, ?, CURRENT, ?, CURRENT)'
+const QUERY_UPDATE = 'UPDATE phase_criteria SET parameter = ?, modify_user = ?, modify_date = CURRENT WHERE project_phase_id = ?'
+const QUERY_DELETE = 'DELETE FROM phase_criteria WHERE project_phase_id = ?'
+
+/**
+ * Prepare Informix statement
+ * @param {Object} connection the Informix connection
+ * @param {String} sql the sql
+ * @return {Object} Informix statement
+ */
+async function prepare (connection, sql) {
+  // logger.debug(`Preparing SQL ${sql}`)
+  const stmt = await connection.prepareAsync(sql)
+  return Promise.promisifyAll(stmt)
+}
+
+/**
+ * Get entry
+ * @param {Number} phaseId the phase ID
+ */
+async function getEntry (phaseId) {
+  // logger.debug(`Getting Groups for Challenge ${challengeLegacyId}`)
+  const connection = await helper.getInformixConnection()
+  let result = null
+  try {
+    result = await connection.queryAsync(util.format(QUERY_GET_ENTRY, phaseId))
+  } catch (e) {
+    logger.error(`Error in 'getEntry' ${e}`)
+    throw e
+  } finally {
+    await connection.closeAsync()
+  }
+  return result
+}
+
+/**
+ * Enable timeline notifications
+ * @param {Number} phaseId the legacy challenge ID
+ * @param {Number} typeId the type ID
+ * @param {Any} value the value
+ * @param {String} createdBy the created by
+ */
+async function createOrSetNumberOfReviewers (phaseId, value, createdBy) {
+  const connection = await helper.getInformixConnection()
+  let result = null
+  try {
+    await connection.beginTransactionAsync()
+    const [existing] = await getEntry(phaseId)
+    if (existing) {
+      if (value) {
+        const query = await prepare(connection, QUERY_UPDATE)
+        result = await query.executeAsync([value, createdBy, phaseId])
+      } else {
+        const query = await prepare(connection, QUERY_DELETE)
+        result = await query.executeAsync([phaseId, value])
+      }
+    } else {
+      const query = await prepare(connection, QUERY_CREATE)
+      result = await query.executeAsync([phaseId, value, createdBy, createdBy])
+    }
+    await connection.commitTransactionAsync()
+  } catch (e) {
+    logger.error(`Error in 'createOrSetNumberOfReviewers' ${e}, rolling back transaction`)
+    await connection.rollbackTransactionAsync()
+    throw e
+  } finally {
+    await connection.closeAsync()
+  }
+  return result
+}
+
+module.exports = {
+  getEntry,
+  createOrSetNumberOfReviewers
+}