Skip to content

Commit f8f3ae9

Browse files
author
Vikas Agarwal
committed
Github issue #574, Discussions: no footer on Discussion tab
-- Adjusted height of the left panel to accommodate the footer.
1 parent 2004ab6 commit f8f3ae9

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

src/components/MessageList/MessageList.jsx

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,8 +57,9 @@ class MessageList extends Component {
5757
componentDidMount() {
5858
const { scrollPosition } = this.props
5959
const panelMessages = this.refs.panelMessages
60-
// 145 = 60 for topbar + 45 for panel title + 20px for margin between topbar and left panel + 10px padding
61-
panelMessages.style.height = (window.innerHeight - 145) + 'px'
60+
// 215 = 60 for topbar + 45 for panel title + 20px for margin between topbar and left panel + 10px padding
61+
// + 60px footer + 10px margin bw footer and left panel
62+
panelMessages.style.height = (window.innerHeight - 215) + 'px'
6263
if (scrollPosition) {
6364
// We use requestAnimationFrame because this function may be executed before
6465
// the DOM elements are actually drawn.

src/projects/detail/Messages.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
@include flexBox;
1919
max-width: 1110px;
2020
margin: 20px auto;
21-
height: calc(100% - 20px);// 20px is for bottom margin
21+
height: calc(100% - 80px);// 20px is for bottom margin, 60px for footer
2222

2323
.left-area {
2424
@include flexWidth(1);

0 commit comments

Comments
 (0)