Skip to content

Commit ebf6691

Browse files
committed
fix: clearing handles in Topcoder Team
also removed redundant method
1 parent cf31e56 commit ebf6691

File tree

2 files changed

+2
-26
lines changed

2 files changed

+2
-26
lines changed

src/components/TeamManagement/ProjectManagementDialog.js

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -61,18 +61,6 @@ class ProjectManagementDialog extends React.Component {
6161
))
6262
}
6363

64-
/**
65-
* Get user handle using `allMembers` which comes from props and contains all the users
66-
* which are loaded to `members.members` in the Redux store
67-
*
68-
* @param {Number} userId user id
69-
*/
70-
resolveUserHandle(userId) {
71-
const { allMembers } = this.props
72-
73-
return _.get(_.find(allMembers, { userId }), 'handle')
74-
}
75-
7664
showIndividualErrors(error) {
7765
const uniqueMessages = _.groupBy(error.failed, 'message')
7866

src/components/TeamManagement/TopcoderManagementDialog.js

Lines changed: 2 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -114,28 +114,16 @@ class TopcoderManagementDialog extends React.Component {
114114
isSelectedMemberAlreadyInvited(topcoderTeamInvites = [], selectedMember) {
115115
return !!topcoderTeamInvites.find((invite) => (
116116
(invite.email && compareEmail(invite.email, selectedMember.label)) ||
117-
(invite.userId && compareHandles(this.resolveUserHandle(invite.userId), selectedMember.label))
117+
(invite.userId && compareHandles(invite.handle, selectedMember.label))
118118
))
119119
}
120120

121-
/**
122-
* Get user handle using `allMembers` which comes from props and contains all the users
123-
* which are loaded to `members.members` in the Redux store
124-
*
125-
* @param {Number} userId user id
126-
*/
127-
resolveUserHandle(userId) {
128-
const { allMembers } = this.props
129-
130-
return _.get(_.find(allMembers, { userId }), 'handle')
131-
}
132-
133121
showIndividualErrors(error) {
134122
const uniqueMessages = _.groupBy(error.failed, 'message')
135123

136124
const msgs = _.keys(uniqueMessages).map((message) => {
137125
const users = uniqueMessages[message].map((failed) => (
138-
failed.email ? failed.email : this.resolveUserHandle(failed.userId)
126+
failed.email ? failed.email : failed.handle
139127
))
140128

141129
return ({

0 commit comments

Comments
 (0)