fixes a bug with project dashboard load when directproject is not created, fixes #486

Author: Parth Shah

src/components/FileList/FileListItem.jsx

@@ -102,7 +102,7 @@ export default class FileListItem extends React.Component {
   }
 
   renderReadOnly() {
-    const {title, description, size, isEditable} = this.props
+    const {title, downloadUrl, description, size, isEditable} = this.props
     const { showDeletionDialog } = this.state
     return (
       <div>
@@ -118,7 +118,7 @@ export default class FileListItem extends React.Component {
           </div>
         </Modal>
         <div className="title">
-          <h4>{title}</h4>
+          <h4><a href={downloadUrl} target="_blank" rel="noopener noreferrer">{title}</a></h4>
           <div className="size">
             {filesize(size)}
           </div>
@@ -131,7 +131,7 @@ export default class FileListItem extends React.Component {
       </div>
     )
   }
-  
+
   render() {
     const {isEditing} = this.state
     let iconPath

src/projects/actions/projectDashboard.js

@@ -18,12 +18,14 @@ const getDashboardData = (dispatch, projectId) => {
         // this is to remove any nulls from the list (dev had some bad data)
         _.remove(userIds, i => !i)
         // load additional data in parallel
+        const promises = [
+          dispatch(loadMembers(userIds))
+        ]
+        if (value.directProjectId)
+          promises.push(dispatch(loadDirectProjectData(value.directProjectId)))
         return resolve(dispatch({
           type: LOAD_ADDITIONAL_PROJECT_DATA,
-          payload: Promise.all([
-            dispatch(loadMembers(userIds)),
-            dispatch(loadDirectProjectData(value.directProjectId))
-          ])
+          payload: Promise.all(promises)
         }))
 
       })

src/projects/actions/projectMember.js

@@ -3,6 +3,7 @@ import { addProjectMember as addMember,
   updateProjectMember as updateMember,
   loadMemberSuggestions as loadMemberSuggestionsAPI
 } from '../../api/projectMembers'
+import { loadMembers } from '../../actions/members'
 
 import {ADD_PROJECT_MEMBER, REMOVE_PROJECT_MEMBER, UPDATE_PROJECT_MEMBER,
  LOAD_MEMBER_SUGGESTIONS
@@ -18,12 +19,25 @@ export function loadMemberSuggestions(value) {
   }
 }
 
-export function addProjectMember(projectId, member) {
-  return (dispatch) => {
+function addProjectMemberWithData(dispatch, projectId, member) {
+  return new Promise((resolve, reject) => {
     return dispatch({
       type: ADD_PROJECT_MEMBER,
       payload: addMember(projectId, member)
     })
+      .then((/*{value, action}*/) => {
+        return resolve(dispatch(loadMembers([member.userId])))
+      })
+      .catch(err => reject(err))
+  })
+}
+
+export function addProjectMember(projectId, member) {
+  return (dispatch) => {
+    return dispatch({
+      type: 'ADD_PROJECT_MEMBER_INIT',
+      payload: addProjectMemberWithData(dispatch, projectId, member)
+    })
   }
 }
 

src/projects/detail/components/SpecQuestions.jsx

@@ -36,9 +36,6 @@ const SpecQuestions = ({questions, project, resetFeatures, showFeaturesDialog})
       label: q.label,
       value: _.get(project, q.fieldName, undefined)
     }
-    if (elemProps.value) {
-      console.log({name: q.fieldName, value: JSON.stringify(elemProps.value)})
-    }
     let ChildElem = ''
     switch (q.type) {
     case 'see-attached-textbox':