fix defaultValue for numberinput and numberinputpositive question type for the project wizard form

maxceem · maxceem · commit d0dc4f5e5901 · 2019-06-04T11:34:39.000+08:00
diff --git a/src/projects/detail/components/SpecQuestions.jsx b/src/projects/detail/components/SpecQuestions.jsx
@@ -178,7 +178,8 @@ const SpecQuestions = ({
       if (!isNaN(q.maxValue)) {
         elemProps.maxValue = q.maxValue
       }
-      if (!isNaN(q.defaultValue)) {
+      // update with default value only if we don't have any value yet
+      if (!elemProps.value && !isNaN(q.defaultValue)) {
         elemProps.value = q.defaultValue
       }
       break
@@ -191,7 +192,8 @@ const SpecQuestions = ({
       if (!isNaN(q.maxValue)) {
         elemProps.maxValue = q.maxValue
       }
-      if (!isNaN(q.defaultValue)) {
+      // update with default value only if we don't have any value yet
+      if (!elemProps.value && !isNaN(q.defaultValue)) {
         elemProps.value = q.defaultValue
       }
       break

Original file line number	Diff line number	Diff line change
`@@ -178,7 +178,8 @@ const SpecQuestions = ({`
`178`	`178`	`if (!isNaN(q.maxValue)) {`
`179`	`179`	`elemProps.maxValue = q.maxValue`
`180`	`180`	`}`
`181`		`- if (!isNaN(q.defaultValue)) {`
	`181`	`+ // update with default value only if we don't have any value yet`
	`182`	`+ if (!elemProps.value && !isNaN(q.defaultValue)) {`
`182`	`183`	`elemProps.value = q.defaultValue`
`183`	`184`	`}`
`184`	`185`	`break`
`@@ -191,7 +192,8 @@ const SpecQuestions = ({`
`191`	`192`	`if (!isNaN(q.maxValue)) {`
`192`	`193`	`elemProps.maxValue = q.maxValue`
`193`	`194`	`}`
`194`		`- if (!isNaN(q.defaultValue)) {`
	`195`	`+ // update with default value only if we don't have any value yet`
	`196`	`+ if (!elemProps.value && !isNaN(q.defaultValue)) {`
`195`	`197`	`elemProps.value = q.defaultValue`
`196`	`198`	`}`
`197`	`199`	`break`