fix: don't use random for report URL

ref issue #3727

Author: maxceem

src/projects/detail/containers/ProjectSummaryReportContainer.jsx

@@ -36,6 +36,9 @@ class ProjectSummaryReportContainer extends React.Component {
   constructor(props) {
     super(props)
 
+    this.state = {
+      iframeKey: 0, // we would use it to force iframe to reload
+    }
     this.timer = null
     this.setLookerSessionTimer = this.setLookerSessionTimer.bind(this)
     this.reloadProjectReport = this.reloadProjectReport.bind(this)
@@ -65,6 +68,13 @@ class ProjectSummaryReportContainer extends React.Component {
       this.props.loadProjectReportsUrls(nextProjectId, PROJECT_REPORTS.PROJECT_SUMMARY)
       // don't have to set session expire timer here, it would be set of iframe load
     }
+
+    // when we get a new URL for report, force iframe to reload, in case the URL stays the same
+    if (this.props.isLoading && !nextProps.isLoading) {
+      this.setState({
+        iframeKey:  this.state.iframeKey + 1
+      })
+    }
   }
 
   setLookerSessionTimer() {
@@ -148,6 +158,7 @@ class ProjectSummaryReportContainer extends React.Component {
             </div>
           </Modal>
           <EnhancedLookerEmbedReport
+            key={this.state.iframeKey}
             isLoading={isLoading}
             projectSummaryEmbedUrl={projectSummaryEmbedUrl}
             onLoad={this.setLookerSessionTimer}

src/projects/reducers/projectReports.js

@@ -14,19 +14,6 @@ const initialState = {
   lookerSessionExpired: false,
 }
 
-/**
- * Adds a `random` query param to the URL so browser could treat such a URL as different.
- *
- * @param {String} url URL string to augment
- *
- * @returns {String} URL with `random` query param
- */
-function addRandomParamToUrl(url) {
-  const randomParam = `random=${Math.random().toString().slice(2)}`
-
-  return url + (url.indexOf('?') > -1 ? '&' : '?') + randomParam
-}
-
 export const projectReports = function (state=initialState, action) {
   const payload = action.payload
 
@@ -43,7 +30,7 @@ export const projectReports = function (state=initialState, action) {
       return Object.assign({}, state, {
         isLoading: false,
         error: false,
-        projectSummaryEmbedUrl: addRandomParamToUrl(payload),
+        projectSummaryEmbedUrl: payload,
         lookerSessionExpired: false,
         // projectSummary: payload
       })