Skip to content

Commit beb9f8d

Browse files
authored
Merge pull request #1654 from appirio-tech/bugBash07
Bug bash07- partial merge
2 parents 1274dc4 + 38007f1 commit beb9f8d

File tree

5 files changed

+10
-45
lines changed

5 files changed

+10
-45
lines changed

src/api/projectMembers.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import { TC_API_URL, PROJECTS_API_URL, CONNECT_MESSAGE_API_URL } from '../config
55
export function getMembersById (userIds) {
66
const _userIdArr = _.map(userIds, _id => `userId:${_id}`)
77
// only requesting certain member attributes
8-
const fields = 'userId,handle,photoURL,firstName,lastName,maxRating,details,email'
8+
const fields = 'userId,handle,photoURL,firstName,lastName,details,email'
99
const query = _userIdArr.join(' OR ')
1010
const url = `${TC_API_URL}/v3/members/_search/?fields=`
1111
+ encodeURIComponent(fields)

src/components/TopBar/ProjectsToolBar.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,7 @@ class ProjectsToolBar extends Component {
145145
excludedFiltersCount++
146146
}
147147
// Ignore status from filters count
148-
const noOfFilters = _.keys(_.omit(criteria, ['status'])).length - excludedFiltersCount
148+
const noOfFilters = _.keys(_.omit(criteria, ['status', 'keyword'])).length - excludedFiltersCount
149149
const onLeaveMessage = this.onLeave() || ''
150150

151151
const primaryNavigationItems = [

src/components/User/UserAvatar.jsx

Lines changed: 0 additions & 36 deletions
This file was deleted.
Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,18 @@
11
import React from 'react'
22
import PropTypes from 'prop-types'
33
import { DOMAIN } from '../../config/constants'
4-
import UserAvatar from './UserAvatar'
4+
import { Avatar } from 'appirio-tech-react-components'
55
require('./UserWithName.scss')
66

7-
const UserWithName = ({ handle, firstName, lastName, photoURL, maxRating={rating: 0}, showLevel=false }) => {
7+
const UserWithName = ({ handle, firstName, lastName, photoURL }) => {
88
const url = `//www.${DOMAIN}/members/${handle}/`
99
return (
1010
<div className="user-block">
1111
<a href={url} target="_blank" rel="noopener noreferrer" className="photo">
12-
<UserAvatar rating={maxRating.rating} showLevel={showLevel} photoURL={photoURL} />
12+
<Avatar
13+
avatarUrl={photoURL}
14+
userName={firstName + ' ' + lastName}
15+
/>
1316
</a>
1417
<span className="txt-box">
1518
<a href={url} target="_blank" rel="noopener noreferrer" className="link-black">{firstName} {lastName}</a>
@@ -23,9 +26,7 @@ UserWithName.propTypes = {
2326
handle : PropTypes.string.isRequired,
2427
firstName : PropTypes.string.isRequired,
2528
lastName : PropTypes.string.isRequired,
26-
photoURL : PropTypes.string,
27-
maxRating : PropTypes.object,
28-
showLevel : PropTypes.bool
29+
photoURL : PropTypes.string
2930
}
3031

3132
export default UserWithName

src/projects/list/components/Projects/ProjectListProjectColHeader.jsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ class ProjectListProjectColHeader extends React.Component {
6161
const activeClass = cn({
6262
active: item.val === currentSortField
6363
})
64-
return (<li key={i} className={activeClass} onClick={sortHandler}>
64+
return (<li key={i} className={activeClass} onClick={() => sortHandler(item.val)}>
6565
{activeClass? <IconCheckDark className="icon-check-dark"/>: ''}
6666
<a href="javascript:;">{item.label}</a>
6767
</li>)

0 commit comments

Comments
 (0)