fix inviting by handles, issue #2846

Author: maxceem

src/components/TeamManagement/AutocompleteInputContainer.jsx

@@ -22,16 +22,13 @@ class AutocompleteInputContainer extends React.Component {
   }
 
   onUpdate(inputValue) {
-    inputValue = inputValue.map(value => {
-      value.isEmail = (/(.+)@(.+){2,}\.(.+){2,}/).test(value.label)
-      if (value.isEmail) {
-        value.handle = value.label
-      }
-      return value
-    })
-	
+    const inputValueNormalized = inputValue.map(value => ({
+      ...value,
+      isEmail: (/(.+)@(.+){2,}\.(.+){2,}/).test(value.label)
+    }))
+
     if (this.props.onUpdate) {
-      this.props.onUpdate(inputValue)
+      this.props.onUpdate(inputValueNormalized)
     }
     this.props.onClearUserSuggestions()
   }

src/components/TeamManagement/ProjectManagementDialog.js

@@ -30,18 +30,18 @@ class Dialog extends React.Component {
   onChange(selectedMembers) {
     // If a member invited with email exists in selectedMembers
     let present = _.some(this.state.invitedMembers, invited => _.findIndex(selectedMembers,
-      selectedMember => selectedMember.isEmail && selectedMember.handle === invited.email) > -1)
+      selectedMember => selectedMember.isEmail && selectedMember.label === invited.email) > -1)
     // If a member invited with handle exists in selectedMembers
     present = present || _.some(this.state.invitedMembers, invited => {
       if (!invited.member) {
         return false
       }
       return _.findIndex(selectedMembers,
-        selectedMember => !selectedMember.isEmail && selectedMember.handle === invited.member.handle) > -1
+        selectedMember => !selectedMember.isEmail && selectedMember.label === invited.member.handle) > -1
     })
     // If members exist in selectedMembers
     present = present || _.some(this.state.members, m => _.findIndex(selectedMembers,
-      selectedMember => selectedMember.handle === m.handle) > -1)
+      selectedMember => selectedMember.label === m.handle) > -1)
     this.setState({
       validInviteText: !present,
       showAlreadyMemberError: present

src/projects/detail/containers/TeamManagementContainer.jsx

@@ -163,7 +163,7 @@ class TeamManagementContainer extends Component {
     const handles = []
     const emails = []
     selectedMembers.map(selectedOption => {
-      const value = selectedOption.handle
+      const value = selectedOption.label
       // Test if its email
       if (selectedOption.isEmail) {
         emails.push(value)