Merge pull request #4477 from appirio-tech/feature/milestone-customer-approval

RishiRajSahu · web-flow · commit 8f9c729775b9 · 2021-09-01T20:49:32.000+05:30
[HOTFIX][DEV] Fixed adding copilot bug in new milestone management
diff --git a/src/projects/detail/components/SimplePlan/components/AddCopilotsSidebar/AddCopilotsSidebar.jsx b/src/projects/detail/components/SimplePlan/components/AddCopilotsSidebar/AddCopilotsSidebar.jsx
@@ -31,11 +31,11 @@ class AddCopilotsSidebar extends React.Component {
   }
 
   componentDidMount() {
-    document.addEventListener('click', this.onClickOutside)
+    document.addEventListener('mousedown', this.onClickOutside)
   }
 
   componentWillUnmount() {
-    document.removeEventListener('click', this.onClickOutside)
+    document.removeEventListener('mousedown', this.onClickOutside)
   }
 
   render() {
diff --git a/src/projects/detail/components/SimplePlan/components/MilestonesApprovalNotification/MilestonesApprovalNotification.jsx b/src/projects/detail/components/SimplePlan/components/MilestonesApprovalNotification/MilestonesApprovalNotification.jsx
@@ -28,6 +28,8 @@ class MilestonesApprovalNotification extends React.Component {
   }
 
   findLatest(approvals) {
+    if(!approvals) return {}
+    
     let d = null
     let maxIndex = 0
     for(let index = 0; index <  approvals.length; index ++) {

Original file line number	Diff line number	Diff line change
`@@ -31,11 +31,11 @@ class AddCopilotsSidebar extends React.Component {`
`31`	`31`	`}`
`32`	`32`
`33`	`33`	`componentDidMount() {`
`34`		`- document.addEventListener('click', this.onClickOutside)`
	`34`	`+ document.addEventListener('mousedown', this.onClickOutside)`
`35`	`35`	`}`
`36`	`36`
`37`	`37`	`componentWillUnmount() {`
`38`		`- document.removeEventListener('click', this.onClickOutside)`
	`38`	`+ document.removeEventListener('mousedown', this.onClickOutside)`
`39`	`39`	`}`
`40`	`40`
`41`	`41`	`render() {`
Original file line number	Diff line number	Diff line change
`@@ -28,6 +28,8 @@ class MilestonesApprovalNotification extends React.Component {`
`28`	`28`	`}`
`29`	`29`
`30`	`30`	`findLatest(approvals) {`
	`31`	`+ if(!approvals) return {}`
	`32`	`+`
`31`	`33`	`let d = null`
`32`	`34`	`let maxIndex = 0`
`33`	`35`	`for(let index = 0; index < approvals.length; index ++) {`