Revert "issue #1991 - Email settings"

This reverts commit c93774f.

Author: maxceem

package-lock.json

@@ -24,9 +24,7 @@ class BtnGroup extends React.Component {
           <button
             key={item.value}
             className={cn('tc-btn tc-btn-sm tc-btn-default', { active: item.value === this.state.value })}
-            onClick={(evt) => {
-              // prevent parent form to be submitted
-              evt.preventDefault()
+            onClick={() => {
               if (item.value !== this.state.value) {
                 this.setState({ value: item.value })
                 if (this.props.onChange) {

src/components/BtnGroup/BtnGroup.jsx

@@ -6,34 +6,24 @@
     > .tc-btn {
       border-radius: 0;
       border-left-width: 0;
-      margin: 0;
     }
-
+  
     > .tc-btn:first-child {
       border-radius: 2 * $corner-radius 0 0 2 * $corner-radius;
       border-left-width: 1px;
     }
-
+  
     > .tc-btn:last-child {
       border-radius: 0 2 * $corner-radius 2 * $corner-radius 0;
     }
-
+  
     > .tc-btn.active,
     > .tc-btn.active:hover,
     > .tc-btn.active:active {
       background: $tc-gray-20;
       box-shadow: inset 0 1px 3px 0 rgba($tc-gray-80, 0.38);
       cursor: default;
     }
-
-    @media screen and (max-width: $screen-md - 1px) {
-      > .tc-btn,
-      > .tc-btn:first-child,
-      > .tc-btn:last-child {
-        border-radius: 2 * $corner-radius;
-        border-width: 1px;
-        margin: 5px;
-      }
-    }
   }
 }
+  

src/components/BtnGroup/BtnGroup.scss

@@ -399,11 +399,3 @@ export const SCREEN_BREAKPOINT_RG = 992
 export const SCREEN_BREAKPOINT_MD = 768
 export const SCREEN_BREAKPOINT_SM = 640
 export const SCREEN_BREAKPOINT_XS = 320
-
-export const NOTIFICATION_SETTINGS_PERIODS = [
-  { text: 'Send as they happen', value: 'immediately' },
-  { text: 'Every 10m.', value: 'every10minutes' },
-  { text: 'Hourly', value: 'hourly' },
-  { text: 'Daily', value: 'daily' },
-  { text: 'Weekly', value: 'weekly' },
-]

src/config/constants.js

@@ -5,9 +5,11 @@
   .settings-panel {
     margin: 20px auto 0;
     padding: 0 20px;
+    min-width: 960px;
 
     @media screen and (max-width: $screen-md - 1px) {
       margin: 0;
+      min-width: 0;
       padding: 0;
     }
 

src/routes/settings/components/SettingsPanel.scss

@@ -5,11 +5,9 @@ import React from 'react'
 import PropTypes from 'prop-types'
 import FormsyForm from 'appirio-tech-react-components/components/Formsy'
 const Formsy = FormsyForm.Formsy
-import { NOTIFICATION_SETTINGS_PERIODS } from '../../../../../config/constants'
 import SwitchButton from 'appirio-tech-react-components/components/SwitchButton/SwitchButton'
 import BtnGroup from '../../../../../components/BtnGroup/BtnGroup'
 import IconSettingsWeb from '../../../../../assets/icons/settings-icon-web.svg'
-import IconSettingsEmail from '../../../../../assets/icons/settings-icon-mail.svg'
 import './NotificationSettingsForm.scss'
 import _ from 'lodash'
 
@@ -80,28 +78,22 @@ const topics = [
  */
 const initSettings = (notInitedSettings) => {
   const settings = {...notInitedSettings}
-  const notifications = {...settings.notifications}
   const allTypes = _.flatten(_.map(topics, 'types'))
 
   allTypes.forEach((type) => {
-    if (!notifications[type]) {
-      notifications[type] = {}
+    if (!settings[type]) {
+      settings[type] = {}
     }
 
-    // check each of serviceId method separately as some can have
+    // check each of deliveryMethod method separately as some can have
     // values and some don't have
-    ['web', 'email'].forEach((serviceId) => {
-      if (!notifications[type][serviceId]) {
-        notifications[type][serviceId] = {}
-      }
-      if (_.isUndefined(notifications[type][serviceId].enabled)) {
-        notifications[type][serviceId].enabled = 'yes'
+    ['web', 'email'].forEach((deliveryMethod) => {
+      if (_.isUndefined(settings[type][deliveryMethod])) {
+        settings[type][deliveryMethod] = 'yes'
       }
     })
   })
 
-  settings.notifications = notifications
-
   return settings
 }
 
@@ -115,45 +107,26 @@ class NotificationSettingsForm extends React.Component {
     }
 
     this.handleChange = this.handleChange.bind(this)
-    this.handleBundleEmailChange = this.handleBundleEmailChange.bind(this)
   }
 
-  handleChange(topicIndex, serviceId) {
-    const notifications = {...this.state.settings.notifications}
+  handleChange(topicIndex, deliveryMethod) {
+    const s = {
+      settings: {
+        ...this.state.settings
+      }
+    }
 
     // update values for all types of the topic
     topics[topicIndex].types.forEach((type) => {
-      notifications[type][serviceId].enabled = notifications[type][serviceId].enabled === 'yes' ? 'no' : 'yes'
-    })
-
-    this.setState({
-      settings: {
-        ...this.state.settings,
-        notifications,
-      }
+      s.settings[type][deliveryMethod] = s.settings[type][deliveryMethod] === 'yes' ? 'no' : 'yes'
     })
-  }
 
-  handleBundleEmailChange(bundlePeriod) {
-    this.setState({
-      settings: {
-        ...this.state.settings,
-        services: {
-          ...this.state.settings.services,
-          email: {
-            ...this.state.settings.services.email,
-            // this will be send to backend which uses null instead of 'immediately'
-            bundlePeriod: bundlePeriod === 'immediately' ? null : bundlePeriod,
-          }
-        }
-      }
-    })
+    this.setState(s)
   }
 
   render() {
     const areSettingsProvided = !!this.props.values.settings
     const settings = this.state.settings
-    const notifications = settings.notifications
 
     // if settings weren't provided (not loaded) don't render anything
     if (!areSettingsProvided) {
@@ -172,9 +145,8 @@ class NotificationSettingsForm extends React.Component {
               <th><span className="th-with-icon">
                 <IconSettingsWeb className="icon-settings-web"/>
                 <span>Web</span></span></th>
-              <th><span className="th-with-icon">
-                <IconSettingsEmail />
-                <span>Email</span></span></th>
+              {/* as email notification currently not supported, hide them for now */}
+              {/*<th><span className="th-with-icon"><img src={iconMail} /><span>Email</span></span></th>*/}
             </tr>
           </thead>
           <tbody>
@@ -185,26 +157,37 @@ class NotificationSettingsForm extends React.Component {
               return (
                 <tr key={index}>
                   <th>{topic.title}</th>
-                  <td><SwitchButton onChange={() => this.handleChange(index, 'web')} defaultChecked={notifications[topicFirstType].web.enabled === 'yes'} /></td>
-                  <td><SwitchButton onChange={() => this.handleChange(index, 'email')} defaultChecked={notifications[topicFirstType].email.enabled === 'yes'} /></td>
+                  <td><SwitchButton onChange={() => this.handleChange(index, 'web')} defaultChecked={settings[topicFirstType] && settings[topicFirstType].web === 'yes'} /></td>
+                  {/* as email notification currently not supported, hide them for now */}
+                  {/*<td><SwitchButton onChange={() => this.handleChange(topic, 'email')} defaultChecked={settings[topic] && settings[topic].email === 'yes'} /></td>*/}
                 </tr>
               )
             })}
-            <tr>
+
+            { false && <tr>
               <td colSpan="3">
                 <div className="bundle-emails">
                   <div className="th">Bundle emails:</div>
                   <BtnGroup
-                    items={NOTIFICATION_SETTINGS_PERIODS}
-                    onChange={this.handleBundleEmailChange}
-                    defaultValue={_.get(this.props.values, 'settings.services.email.bundlePeriod') || 'immediately'}
+                    items={[
+                      { text: 'Send as they happen', value: 'immediately' },
+                      { text: 'Every hour', value: 'hourly' },
+                      { text: 'Every 12h.', value: '12h' },
+                      { text: 'Every 24h.', value: '24h' }
+                    ]}
+                    defaultValue={this.props.values.bundleEmail}
                   />
                 </div>
               </td>
             </tr>
+            }
           </tbody>
         </table>
 
+        <div className="email-settings">
+          <a href="https://www.topcoder.com/settings/email/">Manage email settings</a>
+        </div>
+
         <div className="controls">
           <button type="submit" className="tc-btn tc-btn-primary" disabled={this.props.values.pending}>Save settings</button>
         </div>

src/routes/settings/routes/notifications/components/NotificationSettingsForm.jsx

@@ -104,14 +104,6 @@
           margin-left: 10px;
           margin-bottom: 10px;
         }
-
-        @media screen and (max-width: 430px - 1px) {
-          > span {
-            display: block;
-            margin-left: $base-unit;
-            margin-right: $base-unit;
-          }
-        }
       }
 
       .none {
@@ -143,5 +135,21 @@
       margin-top: 6 * $base-unit;
       text-align: center;
     }
+
+    > .email-settings {
+      @include roboto;
+      margin: 20px 0;
+
+      // Link colors
+      a:link,
+      a:visited {
+        color: $tc-dark-blue;
+      }
+
+      a:hover,
+      a:active {
+        color: $tc-dark-blue-70;
+      }
+    }
   }
 }

src/routes/settings/routes/notifications/components/NotificationSettingsForm.scss

@@ -25,6 +25,10 @@ class NotificationSettingsContainer extends React.Component {
     return (
       <SettingsPanel
         title="Notifications"
+        // link={{
+        //   to: 'https://www.topcoder.com/settings/email/',
+        //   text: 'email settings here'
+        // }}
         text="Notifications are a great way to get back to what matters. Sometimes things can be a bit overwhelming, we get it, so here you can turn off the things that bug you. Once off, you won’t get any notifications of that category until you turn it back on. To manage your email notifications, follow the link at the bottom of the page."
         isWide
       >

src/routes/settings/routes/notifications/containers/NotificationSettingsContainer.jsx

@@ -66,8 +66,42 @@ const getNotificationSettings = () => {
     .then(resp => resp.data)
 }
 
+// TODO move this list to constants together with the same list in NotificationSettingsForm.jsx
+const topics = [
+  'notifications.connect.project.created',
+  'notifications.connect.project.updated',
+  'notifications.connect.project.canceled',
+  'notifications.connect.project.approved',
+  'notifications.connect.project.paused',
+  'notifications.connect.project.completed',
+  'notifications.connect.project.submittedForReview',
+  'notifications.connect.project.active',
+
+  'notifications.connect.project.fileUploaded',
+  'notifications.connect.project.specificationModified',
+  'notifications.connect.project.linkCreated',
+
+  'notifications.connect.project.member.joined',
+  'notifications.connect.project.member.left',
+  'notifications.connect.project.member.removed',
+  'notifications.connect.project.member.managerJoined',
+  'notifications.connect.project.member.copilotJoined',
+  'notifications.connect.project.member.assignedAsOwner',
+
+  'notifications.connect.project.topic.created',
+  'notifications.connect.project.topic.deleted',
+  'notifications.connect.project.post.created',
+  'notifications.connect.project.post.edited',
+  'notifications.connect.project.post.deleted'
+]
+
 const saveNotificationSettings = (data) => {
-  return axios.put(`${TC_NOTIFICATION_URL}/settings`, data)
+  const body = []
+  _.each(topics, (topic) => {
+    body.push({ topic, deliveryMethod: 'email', value: data[topic] && data[topic].email === 'yes' ? 'yes' : 'no' })
+    body.push({ topic, deliveryMethod: 'web', value: data[topic] && data[topic].web === 'yes' ? 'yes' : 'no' })
+  })
+  return axios.put(`${TC_NOTIFICATION_URL}/settings`, body)
 }
 
 export default {