Github issue #225 Must validate the white spaces (Blank spaces)

-- fixed along with lint error fixes

Author: vikasrohit

src/projects/detail/components/FeatureSelector/CustomFeatureForm.jsx

@@ -65,7 +65,7 @@ class CustomFeatureForm extends Component {
       id: data.title.toLowerCase().replace(/\s/g, '_'),
       categoryId: 'custom',
       notes: ''
-    }, featureData, data))
+    }, featureData, { title : data.title.trim() }))
     // assumes addFeature to be a synchronous call, otherwise it could lead to inconsistent UI state 
     // e.g. if async addFeature fails, it would close the edit mode
     // this call is needed here because debounce call (for notes change) is closing the edit mode if
@@ -79,6 +79,8 @@ class CustomFeatureForm extends Component {
     // because forms' onChange event gets fire with only form data when we lose focus from the form
     // alternative to this check is to put the change handler on textarea instead of form
     if (featureData) {// feature is already added
+      // trim the notes (as of now only notes field is auto updated)
+      data.notes = data.notes.trim()
       this.props.updateFeature(_.merge({}, featureData, data))
     }
   }
@@ -117,7 +119,7 @@ class CustomFeatureForm extends Component {
               <TCFormFields.TextInput
                 name="title"
                 label="Feature name"
-                validations="minLength:1" required
+                validations="isRequired" required
                 validationError="Feature name is required"
                 wrapperClass="row"
                 value={ _.get(data, 'title', '') }

src/projects/detail/components/FeatureSelector/DefaultFeatureForm.jsx

@@ -50,6 +50,8 @@ class DefaultFeatureForm extends Component {
 
   onChange(data) {
     const { featureData } = this.props
+    // trim the notes (as of now only notes field is auto updated)
+    data.notes = data.notes.trim()
     this.props.updateFeature(_.merge({}, featureData, data))
   }
 

src/projects/detail/components/FeatureSelector/FeaturePicker.jsx

@@ -214,7 +214,6 @@ class FeaturePicker extends Component {
     this.removeFeature = this.removeFeature.bind(this)
     this.toggleFeature = this.toggleFeature.bind(this)
     this.selectFeature = this.selectFeature.bind(this)
-    this.toggleFeature = this.toggleFeature.bind(this)
     this.updateSelectedFeature = this.updateSelectedFeature.bind(this)
     this.renderCustomFeatureForm = this.renderCustomFeatureForm.bind(this)
     this.renderDefaultFeatureForm = this.renderDefaultFeatureForm.bind(this)
@@ -233,11 +232,6 @@ class FeaturePicker extends Component {
     })
   }
 
-  toggleFeature(featureId) {
-    const idx = _.findIndex(this.state.activeFeatureList, f => f.id === featureId)
-    idx > -1 ? this.removeFeature(featureId) : this.addFeature(featureId)
-  }
-
   renderCustomFeatureForm() {
     this.setState({
       selectedFeatureId: null,