Github issue#2813, Spurious project members are available in the allowed users dropdown

— Fixed

Author: Vikas Agarwal

src/projects/detail/components/FileListContainer.jsx

@@ -110,8 +110,10 @@ const mapDispatchToProps = {
 }
 
 const mapStateToProps = ({ members, projectState, loadUser }) => {
+  const project = projectState.project
+  let projectMembers = _.filter(members.members, m => _.some(project.members, pm => pm.userId === m.userId))
   return {
-    allMembers: members.members,
+    allMembers:  _.keyBy(projectMembers, 'userId'),
     pendingAttachments: projectState.attachmentsAwaitingPermission,
     attachmentPermissions: projectState.attachmentPermissions,
     loggedInUser: loadUser.user,

src/projects/detail/containers/ProjectInfoContainer.js

@@ -315,11 +315,13 @@ ProjectInfoContainer.PropTypes = {
 }
 
 const mapStateToProps = ({ templates, projectState, members, loadUser }) => {
+  const project = projectState.project
+  const projectMembers = _.filter(members.members, m => _.some(project.members, pm => pm.userId === m.userId))
   return ({
     projectTemplates : templates.projectTemplates,
     attachmentsAwaitingPermission: projectState.attachmentsAwaitingPermission,
     attachmentPermissions: projectState.attachmentPermissions,
-    projectMembers: members.members,
+    projectMembers:  _.keyBy(projectMembers, 'userId'),
     loggedInUser: loadUser.user
   })
 }