Skip to content

Commit 48ca809

Browse files
authored
Merge pull request #2672 from appirio-tech/support-profile-update-for-old-profiles
Support profile update for old profiles, fixes after final testing
2 parents 5fc4f85 + 16fba1c commit 48ca809

File tree

2 files changed

+9
-1
lines changed

2 files changed

+9
-1
lines changed

src/routes/settings/actions/index.js

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -201,7 +201,13 @@ export const saveProfileSettings = (settings) => (dispatch, getState) => {
201201
const state = getState()
202202
const handle = _.get(state, 'loadUser.user.handle')
203203
const traits = _.get(state, 'settings.profile.traits')
204-
const existentTraitIds = _.map(traits, 'traitId')
204+
const existentTraitIds = _.map(
205+
// some traits could have categoryName as null
206+
// for such traits we have to use POST method instead of PUT or we will get
207+
// error 404 for such traits
208+
traits.filter((trait) => trait.categoryName),
209+
'traitId'
210+
)
205211
const updatedTraits = applyProfileSettingsToTraits(traits, settings)
206212

207213
// we will only update on server traits which can be updated on the settings page

src/routes/settings/helpers/settings.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -115,12 +115,14 @@ export const applyProfileSettingsToTraits = (traits, profileSettings) => {
115115
const updatedTrait = {...trait}
116116
const [firstName, lastName] = profileSettings.firstNLastName ? profileSettings.firstNLastName.split(/\s+/) : []
117117
const photoURL = profileSettings.photoUrl
118+
const country = profileSettings.country
118119

119120
// update only if new values are defined
120121
const updatedProps = _.omitBy({
121122
photoURL,
122123
firstName,
123124
lastName,
125+
country,
124126
}, _.isUndefined)
125127

126128
updatedTrait.traits = {

0 commit comments

Comments
 (0)