Merge pull request #2783 from appirio-tech/revert-2778-issue_2750

maxceem · web-flow · commit 401174335362 · 2019-01-24T18:56:12.000+08:00
Accidently merged to dev. Should have been merged to `cf14` instead. Revert "fixed issue #2750"
diff --git a/src/components/NotificationsDropdown/EnhancedDropdown.jsx b/src/components/NotificationsDropdown/EnhancedDropdown.jsx
@@ -30,7 +30,7 @@ class EnhancedDropdown extends Dropdown{
 
     if (!isDropdown) {
       this.setState({ isOpen: false }, () => {
-        this.props.onToggle(false)
+        this.props.onToggle()
         this.refreshEventHandlers()
       })
     }
diff --git a/src/components/NotificationsDropdown/NotificationsDropdownContainer.jsx b/src/components/NotificationsDropdown/NotificationsDropdownContainer.jsx
@@ -119,8 +119,8 @@ const NotificationsDropdownContainerView = (props) => {
             <NotificationsDropdown 
               hasUnread={hasUnread} 
               hasNew={hasNew} 
-              onToggle={(isOpen) => {
-                toggleNotificationsDropdownWeb(isOpen)
+              onToggle={() => {
+                toggleNotificationsDropdownWeb()
                 visitNotifications()
               }}
             >

Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,7 @@ class EnhancedDropdown extends Dropdown{`
`30`	`30`
`31`	`31`	`if (!isDropdown) {`
`32`	`32`	`this.setState({ isOpen: false }, () => {`
`33`		`- this.props.onToggle(false)`
	`33`	`+ this.props.onToggle()`
`34`	`34`	`this.refreshEventHandlers()`
`35`	`35`	`})`
`36`	`36`	`}`