Github issue #320 [Search] - when filters are hide don't take them into consideration

-- Better way to handle the criteria change. Earlier it was modifying the criteria from the props which was causing no change in state even if we are dispatching and handling GET_PROJECTS_SEARCH_CRITERIA action.

Author: Vikas Agarwal

src/components/TopBar/TopBar.jsx

@@ -95,7 +95,7 @@ class TopBar extends Component {
     if (isProjectDetails) {
       return <ProjectToolBar isPowerUser={isPowerUser} logo={logo} avatar={avatar} project={project} />
     }
-    const noOfFilters = _.keys(criteria).length - 1
+    const noOfFilters = _.keys(criteria).length - 1 // -1 for default sort criteria
 
     return (
       // <Sticky>

src/projects/list/components/Projects/Projects.jsx

@@ -22,13 +22,14 @@ class Projects extends Component {
     // check for criteria specified in URL.
     const queryParams = _.get(this.props, 'location.query', null)
     if (!_.isEmpty(queryParams)) {
-      if (queryParams.sort) criteria.sort = queryParams.sort
-      if (queryParams.name) criteria.name = decodeURIComponent(queryParams.name)
-      if (queryParams.status) criteria.status = queryParams.status
-      if (queryParams.type) criteria.type = queryParams.type
-      if (queryParams.memberOnly) criteria.memberOnly = queryParams.memberOnly
+      const initialCriteria = {}
+      if (queryParams.sort) initialCriteria.sort = queryParams.sort
+      if (queryParams.name) initialCriteria.name = decodeURIComponent(queryParams.name)
+      if (queryParams.status) initialCriteria.status = queryParams.status
+      if (queryParams.type) initialCriteria.type = queryParams.type
+      if (queryParams.memberOnly) initialCriteria.memberOnly = queryParams.memberOnly
       if (queryParams.page) pageNum = parseInt(queryParams.page)
-      loadProjects(criteria, pageNum)
+      loadProjects(initialCriteria, pageNum)
     } else {
       this.routeWithParams(criteria, pageNum)
     }

src/projects/reducers/projectSearch.js

@@ -28,7 +28,7 @@ export default function(state = initialState, action) {
     })
   case GET_PROJECTS_SEARCH_CRITERIA:
     return Object.assign({}, state, {
-      criteria: Object.assign({}, action.criteria ),
+      criteria: action.criteria,
       pageNum: action.pageNum
     })
   case CLEAR_PROJECT_SEARCH: