Skip to content

Commit 18b57eb

Browse files
committed
fix 1655
1 parent 3b61762 commit 18b57eb

File tree

1 file changed

+8
-2
lines changed

1 file changed

+8
-2
lines changed

src/projects/list/components/Projects/ProjectListTimeSortColHeader.jsx

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ class ProjectListTimeSortColHeader extends React.Component {
1919
constructor(props) {
2020
super(props)
2121
this.state = { focused: false }
22+
this.onOutsideClick = this.onOutsideClick.bind(this)
2223
}
2324

2425
toggleFocusState() {
@@ -40,7 +41,12 @@ class ProjectListTimeSortColHeader extends React.Component {
4041
}
4142

4243
componentDidMount() {
43-
document.addEventListener('click', ev => this.onOutsideClick(ev))
44+
document.removeEventListener('click', this.onOutsideClick)
45+
document.addEventListener('click', this.onOutsideClick)
46+
}
47+
48+
componentWillUnmount() {
49+
document.removeEventListener('click', this.onOutsideClick)
4450
}
4551

4652
render() {
@@ -62,7 +68,7 @@ class ProjectListTimeSortColHeader extends React.Component {
6268
const activeClass = cn({
6369
active: item.val === currentSortField
6470
})
65-
return (<li key={i} className={activeClass} onClick={sortHandler}>
71+
return (<li key={i} className={activeClass} onClick={() => sortHandler(item.val)}>
6672
{activeClass? <IconCheckDark className="icon-check-dark"/>: ''}
6773
<a href="javascript:;">{item.label}</a>
6874
</li>)

0 commit comments

Comments
 (0)