Commit 9227457
authored
Bug Fix: Update runs_data_source to request hparams data using FormData (#6334)
## Motivation for features / changes
The dashboard will not load when `inColab` is true because the runs data
cannot be fetched.
Googlers see b/278706604 for why this is important
## Technical description of changes
When `inColab` is true `POST` requests are automatically converted to
`GET` requests see
[tensorboard/webapp/webapp_data_source/tb_http_client.ts](https://github.com/tensorflow/tensorboard/blob/master/tensorboard/webapp/webapp_data_source/tb_http_client.ts).
This conversion assumes the provided body is of type `FormData`,
however, when I open sourced `runs_data_source` in #6318 I was unaware
of this conversion taking place and didn't modify the format of the post
request body.
## Screenshots of UI changes
Before:

After:

## Detailed steps to verify changes work correctly (as executed by you)
1) Start tensorboard
2) Navigate to http://localhost:6006?tensorboardColab#timeseries
3) Assert that the dashboard loads
## Alternate designs / implementations considered
I could have updated the conversion happening in
[tensorboard/webapp/webapp_data_source/tb_http_client.ts](https://github.com/tensorflow/tensorboard/blob/master/tensorboard/webapp/webapp_data_source/tb_http_client.ts)
to accept JSON bodies1 parent 1416f8b commit 9227457
1 file changed
+3
-8
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
74 | 74 | | |
75 | 75 | | |
76 | 76 | | |
77 | | - | |
78 | | - | |
79 | | - | |
80 | | - | |
81 | 77 | | |
82 | 78 | | |
83 | 79 | | |
| |||
98 | 94 | | |
99 | 95 | | |
100 | 96 | | |
101 | | - | |
102 | | - | |
103 | | - | |
| 97 | + | |
| 98 | + | |
104 | 99 | | |
105 | 100 | | |
106 | 101 | | |
107 | | - | |
| 102 | + | |
108 | 103 | | |
109 | 104 | | |
110 | 105 | | |
| |||
0 commit comments