Commit 5f44f55
authored
Linked Time: Remove step selection overrides when global range selection is toggled (#6262)
## Motivation for features / changes
See #6240 for context around why the step selector is being moved to
redux.
Part of this has involved decoupling card specific step and range
selection from the global values.
For Googlers see [internal test failures](
https://fusion2.corp.google.com/invocations/88e32921-2cbc-4924-9dcc-986ffaa5f6a2/targets/%2F%2Flearning%2Fbrain%2Ftensorboard%2Fservice%2Ftbcorp%2Fwebtests:linked_time_complex_test_chrome-linux/tests)
## Technical Description of Changes
Whenever the global range selection value is changed, I remove all step
selection overrides at the reducer level.
## Screenshots of UI changes

## Detailed steps to verify changes work correctly (as executed by you)
1) Patch #6240
2) Start tensorboard
3) Navigate to localhost:6006
4) Enable global step selection
5) Remove the start fob from a scalar card
6) Enable global range selection
7) Ensure start and end fobs appear on all cards1 parent 08294c4 commit 5f44f55
File tree
2 files changed
+6
-0
lines changed- tensorboard/webapp/metrics/store
2 files changed
+6
-0
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1090 | 1090 | | |
1091 | 1091 | | |
1092 | 1092 | | |
| 1093 | + | |
1093 | 1094 | | |
1094 | 1095 | | |
1095 | 1096 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3403 | 3403 | | |
3404 | 3404 | | |
3405 | 3405 | | |
| 3406 | + | |
3406 | 3407 | | |
3407 | 3408 | | |
3408 | 3409 | | |
| 3410 | + | |
3409 | 3411 | | |
3410 | 3412 | | |
3411 | 3413 | | |
| |||
3414 | 3416 | | |
3415 | 3417 | | |
3416 | 3418 | | |
| 3419 | + | |
3417 | 3420 | | |
3418 | 3421 | | |
3419 | 3422 | | |
| 3423 | + | |
3420 | 3424 | | |
3421 | 3425 | | |
3422 | 3426 | | |
| 3427 | + | |
3423 | 3428 | | |
3424 | 3429 | | |
3425 | 3430 | | |
| |||
0 commit comments