Merge branch '7.4' into 8.0

* 7.4:
  [FrameworkBundle] Fix test on read-only directory on Windows
  [Config] Deprecate config builder generators

Author: nicolas-grekas

CHANGELOG.md

@@ -37,6 +37,7 @@ CHANGELOG
  * Add support for union types with `Symfony\Component\EventDispatcher\Attribute\AsEventListener`
  * Add `framework.allowed_http_method_override` option
  * Initialize `router.request_context`'s `_locale` parameter to `%kernel.default_locale%`
+ * Deprecate `ConfigBuilderCacheWarmer`, return PHP arrays from your config instead
 
 7.3
 ---

CacheWarmer/ConfigBuilderCacheWarmer.php

@@ -29,6 +29,8 @@
  * Generate all config builders.
  *
  * @author Tobias Nyholm <tobias.nyholm@gmail.com>
+ *
+ * @deprecated since Symfony 7.4
  */
 final class ConfigBuilderCacheWarmer implements CacheWarmerInterface
 {

Resources/config/services.php

@@ -13,7 +13,6 @@
 
 use Psr\Clock\ClockInterface as PsrClockInterface;
 use Psr\EventDispatcher\EventDispatcherInterface as PsrEventDispatcherInterface;
-use Symfony\Bundle\FrameworkBundle\CacheWarmer\ConfigBuilderCacheWarmer;
 use Symfony\Bundle\FrameworkBundle\HttpCache\HttpCache;
 use Symfony\Component\Clock\Clock;
 use Symfony\Component\Clock\ClockInterface;
@@ -234,9 +233,6 @@ class_exists(WorkflowEvents::class) ? WorkflowEvents::ALIASES : []
             ->args([
                 service('container.getenv'),
             ])
-        ->set('config_builder.warmer', ConfigBuilderCacheWarmer::class)
-            ->args([service(KernelInterface::class), service('logger')->nullOnInvalid()])
-            ->tag('kernel.cache_warmer')
 
         ->set('clock', Clock::class)
         ->alias(ClockInterface::class, 'clock')

Tests/CacheWarmer/ConfigBuilderCacheWarmerTest.php

@@ -11,6 +11,8 @@
 
 namespace Symfony\Bundle\FrameworkBundle\Tests\CacheWarmer;
 
+use PHPUnit\Framework\Attributes\Group;
+use PHPUnit\Framework\Attributes\IgnoreDeprecations;
 use Symfony\Bundle\FrameworkBundle\CacheWarmer\ConfigBuilderCacheWarmer;
 use Symfony\Bundle\FrameworkBundle\FrameworkBundle;
 use Symfony\Bundle\FrameworkBundle\Tests\TestCase;
@@ -31,7 +33,9 @@
 use Symfony\Component\HttpKernel\Kernel;
 use Symfony\Component\HttpKernel\KernelInterface;
 
-class ConfigBuilderCacheWarmerTest extends TestCase
+#[IgnoreDeprecations]
+#[Group('legacy')]
+final class ConfigBuilderCacheWarmerTest extends TestCase
 {
     private string $varDir;
 

Tests/DependencyInjection/Compiler/PhpConfigReferenceDumpPassTest.php

@@ -61,6 +61,10 @@ public function testProcessWithConfigDir()
 
     public function testProcessIgnoresFileWriteErrors()
     {
+        if ('\\' === \DIRECTORY_SEPARATOR) {
+            self::markTestSkipped('Cannot reliably make directory read-only on Windows.');
+        }
+
         // Create a read-only directory to simulate write errors
         $readOnlyDir = $this->tempDir.'/readonly';
         mkdir($readOnlyDir, 0o444, true);