Merge branch '4.3' into 4.4

* 4.3:
  fixed CS
  fixed CS
  fixed CS
  Do not log or call the proxy function when the locale is the same
  Added missing required dependencies on psr/cache and psr/container in symfony/cache-contracts and symfony/service-contracts respectively.
  [HttpClient] fix closing debug stream prematurely
  [Mailer] made code more robust
  Restore compatibility with php 5.5
  fixed sender/recipients in SMTP Envelope
  collect called listeners information only once
  [HttpKernel] Remove TestEventDispatcher.

Author: fabpot

CacheWarmer/AnnotationsCacheWarmer.php

@@ -40,7 +40,7 @@ public function __construct(Reader $annotationReader, string $phpArrayFile, $exc
         if ($excludeRegexp instanceof CacheItemPoolInterface) {
             @trigger_error(sprintf('The CacheItemPoolInterface $fallbackPool argument of "%s()" is deprecated since Symfony 4.2, you should not pass it anymore.', __METHOD__), E_USER_DEPRECATED);
             $excludeRegexp = $debug;
-            $debug = 4 < \func_num_args() && \func_get_arg(4);
+            $debug = 4 < \func_num_args() && func_get_arg(4);
         }
         parent::__construct($phpArrayFile);
         $this->annotationReader = $annotationReader;

CacheWarmer/SerializerCacheWarmer.php

@@ -36,7 +36,7 @@ class SerializerCacheWarmer extends AbstractPhpFileCacheWarmer
      */
     public function __construct(array $loaders, string $phpArrayFile)
     {
-        if (2 < \func_num_args() && \func_get_arg(2) instanceof CacheItemPoolInterface) {
+        if (2 < \func_num_args() && func_get_arg(2) instanceof CacheItemPoolInterface) {
             @trigger_error(sprintf('The CacheItemPoolInterface $fallbackPool argument of "%s()" is deprecated since Symfony 4.2, you should not pass it anymore.', __METHOD__), E_USER_DEPRECATED);
         }
         parent::__construct($phpArrayFile);

DependencyInjection/FrameworkExtension.php

@@ -1115,12 +1115,12 @@ private function registerTranslatorConfiguration(array $config, ContainerBuilder
         $defaultDir = $container->getParameterBag()->resolveValue($config['default_path']);
         $rootDir = $container->getParameter('kernel.root_dir');
         foreach ($container->getParameter('kernel.bundles_metadata') as $name => $bundle) {
-            if (\is_dir($dir = $bundle['path'].'/Resources/translations')) {
+            if (is_dir($dir = $bundle['path'].'/Resources/translations')) {
                 $dirs[] = $dir;
             } else {
                 $nonExistingDirs[] = $dir;
             }
-            if (\is_dir($dir = $rootDir.sprintf('/Resources/%s/translations', $name))) {
+            if (is_dir($dir = $rootDir.sprintf('/Resources/%s/translations', $name))) {
                 @trigger_error(sprintf('Translations directory "%s" is deprecated since Symfony 4.2, use "%s" instead.', $dir, $defaultDir), E_USER_DEPRECATED);
                 $dirs[] = $dir;
             } else {
@@ -1129,7 +1129,7 @@ private function registerTranslatorConfiguration(array $config, ContainerBuilder
         }
 
         foreach ($config['paths'] as $dir) {
-            if (\is_dir($dir)) {
+            if (is_dir($dir)) {
                 $dirs[] = $transPaths[] = $dir;
             } else {
                 throw new \UnexpectedValueException(sprintf('%s defined in translator.paths does not exist or is not a directory', $dir));
@@ -1144,13 +1144,13 @@ private function registerTranslatorConfiguration(array $config, ContainerBuilder
             $container->getDefinition('console.command.translation_update')->replaceArgument(6, $transPaths);
         }
 
-        if (\is_dir($defaultDir)) {
+        if (is_dir($defaultDir)) {
             $dirs[] = $defaultDir;
         } else {
             $nonExistingDirs[] = $defaultDir;
         }
 
-        if (\is_dir($dir = $rootDir.'/Resources/translations')) {
+        if (is_dir($dir = $rootDir.'/Resources/translations')) {
             if ($dir !== $defaultDir) {
                 @trigger_error(sprintf('Translations directory "%s" is deprecated since Symfony 4.2, use "%s" instead.', $dir, $defaultDir), E_USER_DEPRECATED);
             }
@@ -1187,7 +1187,7 @@ private function registerTranslatorConfiguration(array $config, ContainerBuilder
                 $translator->getArgument(4),
                 [
                     'resource_files' => $files,
-                    'scanned_directories' => \array_merge($dirs, $nonExistingDirs),
+                    'scanned_directories' => array_merge($dirs, $nonExistingDirs),
                 ]
             );
 

Test/WebTestAssertionsTrait.php

@@ -195,7 +195,7 @@ private static function getClient(KernelBrowser $newClient = null): ?KernelBrows
         }
 
         if (!$client instanceof KernelBrowser) {
-            static::fail(\sprintf('A client must be set to make assertions on it. Did you forget to call "%s::createClient()"?', __CLASS__));
+            static::fail(sprintf('A client must be set to make assertions on it. Did you forget to call "%s::createClient()"?', __CLASS__));
         }
 
         return $client;