feature #31821 [FrameworkBundle][TwigBundle] Add missing deprecations for PHP templating layer (yceruto)

This PR was merged into the 4.4 branch.

Discussion
----------

[FrameworkBundle][TwigBundle] Add missing deprecations for PHP templating layer

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | yes
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

As part of symfony/symfony#21035 and symfony/symfony@7169f4d

Commits
-------

61613d0bf0 Add missing deprecations for PHP templating layer

Author: fabpot

CHANGELOG.md

@@ -1,6 +1,11 @@
 CHANGELOG
 =========
 
+4.4.0
+-----
+
+ * Deprecated support for `templating` engine in `TemplateController`, use Twig instead
+
 4.3.0
 -----
 

Controller/TemplateController.php

@@ -29,6 +29,10 @@ class TemplateController
 
     public function __construct(Environment $twig = null, EngineInterface $templating = null)
     {
+        if (null !== $templating) {
+            @trigger_error(sprintf('Using a "%s" instance for "%s" is deprecated since version 4.4; use a \Twig\Environment instance instead.', EngineInterface::class, __CLASS__), E_USER_DEPRECATED);
+        }
+
         $this->twig = $twig;
         $this->templating = $templating;
     }

Tests/Controller/TemplateControllerTest.php

@@ -31,6 +31,9 @@ public function testTwig()
         $this->assertEquals('bar', $controller('mytemplate')->getContent());
     }
 
+    /**
+     * @group legacy
+     */
     public function testTemplating()
     {
         $templating = $this->getMockBuilder(EngineInterface::class)->getMock();