Avoiding edge case

weaverryan · weaverryan · commit 147f4e266b90 · 2022-01-18T13:10:12.000-05:00
Sometimes the API will return a PR from some other repository... and nothing else.
Skip this.
diff --git a/src/GithubApi.php b/src/GithubApi.php
@@ -160,6 +160,10 @@ public function getPullRequestForCommit(string $commit, string $repo): ?array
             }
         }
 
+        if (!$bestItem) {
+            return null;
+        }
+
         return [
             'number' => $bestItem['number'],
             'url' => $bestItem['html_url'],

Original file line number	Diff line number	Diff line change
`@@ -160,6 +160,10 @@ public function getPullRequestForCommit(string $commit, string $repo): ?array`
`160`	`160`	`}`
`161`	`161`	`}`
`162`	`162`
	`163`	`+ if (!$bestItem) {`
	`164`	`+ return null;`
	`165`	`+ }`
	`166`	`+`
`163`	`167`	`return [`
`164`	`168`	`'number' => $bestItem['number'],`
`165`	`169`	`'url' => $bestItem['html_url'],`