review fixes

artemredkin · artemredkin · commit 97a8e96299db · 2020-06-15T13:47:43.000+01:00
diff --git a/Sources/AsyncHTTPClient/HTTPHandler.swift b/Sources/AsyncHTTPClient/HTTPHandler.swift
@@ -841,12 +841,12 @@ extension TaskHandler: ChannelDuplexHandler {
                 let promise = self.task.eventLoop.makePromise(of: Void.self)
                 // All writes have to be switched to the channel EL if channel and task ELs differ
                 if context.eventLoop.inEventLoop {
-                    context.writeAndFlush(self.wrapOutboundOut(.body(part)), promise: promise)
                     self.actualBodyLength += part.readableBytes
+                    context.writeAndFlush(self.wrapOutboundOut(.body(part)), promise: promise)
                 } else {
                     context.eventLoop.execute {
-                        context.writeAndFlush(self.wrapOutboundOut(.body(part)), promise: promise)
                         self.actualBodyLength += part.readableBytes
+                        context.writeAndFlush(self.wrapOutboundOut(.body(part)), promise: promise)
                     }
                 }
 
diff --git a/Tests/AsyncHTTPClientTests/HTTPClientTestUtils.swift b/Tests/AsyncHTTPClientTests/HTTPClientTestUtils.swift
@@ -361,9 +361,6 @@ internal struct HTTPResponseBuilder {
     }
 }
 
-// let globalRequestCounter = NIOAtomic<Int>.makeAtomic(value: 0)
-// let globalConnectionCounter = NIOAtomic<Int>.makeAtomic(value: 0)
-
 internal struct RequestInfo: Codable {
     var data: String
     var requestNumber: Int

Original file line number	Diff line number	Diff line change
`@@ -841,12 +841,12 @@ extension TaskHandler: ChannelDuplexHandler {`
`841`	`841`	`let promise = self.task.eventLoop.makePromise(of: Void.self)`
`842`	`842`	`// All writes have to be switched to the channel EL if channel and task ELs differ`
`843`	`843`	`if context.eventLoop.inEventLoop {`
`844`		`- context.writeAndFlush(self.wrapOutboundOut(.body(part)), promise: promise)`
`845`	`844`	`self.actualBodyLength += part.readableBytes`
	`845`	`+ context.writeAndFlush(self.wrapOutboundOut(.body(part)), promise: promise)`
`846`	`846`	`} else {`
`847`	`847`	`context.eventLoop.execute {`
`848`		`- context.writeAndFlush(self.wrapOutboundOut(.body(part)), promise: promise)`
`849`	`848`	`self.actualBodyLength += part.readableBytes`
	`849`	`+ context.writeAndFlush(self.wrapOutboundOut(.body(part)), promise: promise)`
`850`	`850`	`}`
`851`	`851`	`}`
`852`	`852`
Original file line number	Diff line number	Diff line change
`@@ -361,9 +361,6 @@ internal struct HTTPResponseBuilder {`
`361`	`361`	`}`
`362`	`362`	`}`
`363`	`363`
`364`		`-// let globalRequestCounter = NIOAtomic<Int>.makeAtomic(value: 0)`
`365`		`-// let globalConnectionCounter = NIOAtomic<Int>.makeAtomic(value: 0)`
`366`		`-`
`367`	`364`	`internal struct RequestInfo: Codable {`
`368`	`365`	`var data: String`
`369`	`366`	`var requestNumber: Int`