fix in multimodal creation

Author: Narek Mkhitaryan

src/superannotate/lib/app/interface/sdk_interface.py

@@ -1211,7 +1211,11 @@ def create_project(
         project = project_response.data
         if form:
             form_response = self.controller.projects.attach_form(project, form)
-            form_response.raise_for_status()
+            try:
+                form_response.raise_for_status()
+            except AppException:
+                self.controller.projects.delete(project)
+                raise
         if classes:
             classes_response = self.controller.annotation_classes.create_multiple(
                 project, classes

src/superannotate/lib/core/entities/multimodal_form.py

@@ -201,7 +201,7 @@ def generate_class(self):
             "attribute_groups": [
                 {
                     "name": f"value_{self.id}",
-                    "group_type": "single_select",
+                    "group_type": "radio",
                     "attributes": attributes,
                     "default_value": default_value or "",
                 }

src/superannotate/lib/core/usecases/projects.py

@@ -1005,13 +1005,15 @@ def __init__(
         self._service_provider = service_provider
         self._form = form
         self._classes = None
+        self._entity = None
 
     def validate_form(self):
         if self._form is None:
             raise AppException("Form was not provided.")
         try:
             self._entity = FormModel(**self._form)
         except ValidationError:
+            self._service_provider.projects.delete(self._project)
             raise AppException(
                 "The provided form object is invalid or does not match the required schema."
             )

src/superannotate/lib/infrastructure/controller.py

@@ -596,12 +596,11 @@ def add_contributors(
         project: ProjectEntity,
         contributors: List[ContributorEntity],
     ):
-        project = self.get_metadata(project).data
+        project = self.get_metadata(project, include_contributors=True).data
         for contributor in contributors:
             contributor.user_role = self.service_provider.get_role_name(
                 project, contributor.user_role
             )
-        project = self.get_metadata(project).data
         use_case = usecases.AddContributorsToProject(
             team=team,
             project=project,

tests/data_set/multimodal_form/form.json

@@ -126,7 +126,7 @@
                               "label": "Radio",
                               "isRequired": false,
                               "value": "",
-                              "exclude": true,
+                              "exclude": false,
                               "disablePasting": false,
                               "options": [
                                 {

tests/integration/projects/test_multimodal_creation.py

@@ -1,5 +1,7 @@
 import json
 from unittest import TestCase
+from unittest.mock import MagicMock
+from unittest.mock import patch
 
 from src.superannotate import AppException
 from src.superannotate import SAClient
@@ -181,3 +183,39 @@ def test_create_project_invalid_form_structure(self):
                 self.PROJECT_TYPE,
                 form=invalid_form,
             )
+
+    def test_create_project_form_attach_failure_cleanup(self):
+        """Test that project is deleted when form attachment fails"""
+        with open(self.FORM_PATH) as f:
+            form_data = json.load(f)
+
+        # Mock the controller to simulate form attachment failure
+        with patch.object(
+            sa.controller.projects, "attach_form"
+        ) as mock_attach_form, patch.object(
+            sa.controller.projects, "delete"
+        ) as mock_delete:
+            # Create a mock response that raises AppException when raise_for_status is called
+            mock_response = MagicMock()
+            mock_response.raise_for_status.side_effect = AppException(
+                "Form attachment failed"
+            )
+            mock_attach_form.return_value = mock_response
+
+            # Attempt to create project - should fail and trigger cleanup
+            with self.assertRaises(AppException) as context:
+                sa.create_project(
+                    self.PROJECT_NAME,
+                    "desc",
+                    self.PROJECT_TYPE,
+                    form=form_data,
+                )
+
+            # Verify form attachment was attempted
+            mock_attach_form.assert_called_once()
+
+            # Verify project deletion was called for cleanup
+            mock_delete.assert_called_once()
+
+            # Verify the original exception is re-raised
+            assert "Form attachment failed" in str(context.exception)