Merge pull request #743 from superannotateai/custom_fields

fixed in serialize_custom_fields

Author: VaghinakDev

src/superannotate/lib/infrastructure/controller.py

@@ -75,9 +75,7 @@ def build_condition(**kwargs) -> Condition:
 def serialize_custom_fields(
     service_provider: ServiceProvider, data: List[dict], entity: CustomFieldEntityEnum
 ) -> List[dict]:
-    existing_custom_fields = service_provider.list_custom_field_names(
-        CustomFieldEntityEnum.PROJECT
-    )
+    existing_custom_fields = service_provider.list_custom_field_names(entity)
     for i in range(len(data)):
         if not data[i]:
             data[i] = {}

tests/integration/work_management/test_project_custom_fields.py

@@ -132,7 +132,6 @@ def test_set_project_custom_field_validation(
                 self.PROJECT_NAME, "SDK_test_single_select", 123
             )
 
-    # TODO BED issue ("projects/search" endpoint return other teams projects)
     def test_list_projects_by_native_fields(self):
         projects = sa.list_projects(name=self.PROJECT_NAME)
         assert len(projects) == 1
@@ -333,11 +332,3 @@ def test_list_projects_by_custom_invalid_field(self):
     def test_list_projects_by_custom_fields_without_join(self):
         self._set_custom_field_values()
         assert sa.list_projects(custom_field__SDK_test_numeric=123)
-
-    # TODO BED issue ("projects/search" endpoint return other teams projects)
-    def test_list_projects_by_status_in(self):
-        all_team_ids = [
-            i["team_id"] for i in sa.list_projects(status__in=["inProgress"])
-        ]
-        assert len(set(all_team_ids)) == 1
-        assert all_team_ids[0] == sa.controller.team_id

tests/integration/work_management/test_user_custom_fields.py

@@ -48,7 +48,13 @@ def tearDownClass(cls) -> None:
                 )
 
     def test_get_set_user_metadata(self):
+        users = sa.list_users(include=["custom_fields"])
+        for data in CUSTOM_FIELD_PAYLOADS:
+            assert data["name"] in users[0]["custom_fields"]
+
         users = sa.list_users()
+        for user in users:
+            assert user["custom_fields"] == {}
         scapegoat = [u for u in users if u["role"] == "Contributor"][0]
         assert not scapegoat["custom_fields"]
         # text field