Use the non-deprecated version also for nec and portalcli

Author: kdeme

execution_chain/nimbus_execution_client.nim

@@ -98,8 +98,17 @@ proc setupP2P(nimbus: NimbusNode, config: ExecutionClientConf, com: CommonRef) =
       fatal "Get network keys error", msg = error
       quit(QuitFailure)
     natId = NimbusName & " " & NimbusVersion
-    (extIp, extTcpPort, extUdpPort) =
-      setupAddress(config.nat, config.listenAddress, config.tcpPort, config.udpPort, natId)
+    (extIp, extPorts) = setupAddress(
+      config.nat,
+      config.listenAddress,
+      @[
+        (port: config.tcpPort, protocol: PortProtocol.TCP),
+        (port: config.udpPort, protocol: PortProtocol.UDP),
+      ],
+      natId,
+    )
+    extTcpPort = extPorts[0].toPort()
+    extUdpPort = extPorts[1].toPort()
 
     bootstrapNodes = config.getBootstrapNodes()
     fc = nimbus.fc

portal/tools/portalcli.nim

@@ -220,9 +220,13 @@ proc run(config: PortalCliConf) =
     rng = newRng()
     bindIp = config.listenAddress
     udpPort = Port(config.udpPort)
-    # TODO: allow for no TCP port mapping!
-    (extIp, _, extUdpPort) =
-      setupAddress(config.nat, config.listenAddress, udpPort, udpPort, "portalcli")
+    (extIp, extPorts) = setupAddress(
+      config.nat,
+      config.listenAddress,
+      @[(port: udpPort, protocol: PortProtocol.UDP)],
+      "portalcli",
+    )
+    extUdpPort = extPorts[0].toPort()
 
   var bootstrapRecords: seq[Record]
   loadBootstrapFile(string config.bootstrapNodesFile, bootstrapRecords)