revert: use old library for secp256k1 functions

These should eventually switch over to using the Rust-native `k256`
crate from RustCrypto, but for now, we are reverting this to allow more
time to ensure there are no accidental consensus breaking changes.

Author: obycode

Cargo.lock

@@ -45,7 +45,6 @@ slog-term = { version = "2.6.0", default-features = false }
 thiserror = { workspace = true }
 
 # RustCrypto elliptic curve crates
-k256 = { version = "0.13", default-features = false, features = ["std", "serde", "ecdsa"] }
 p256 = { version = "0.13", default-features = false, features = ["std", "serde", "ecdsa"] }
 
 # Optional dependencies
@@ -65,8 +64,12 @@ winapi = { version = "0.3", features = [
 ], optional = true }
 
 [target.'cfg(not(target_family = "wasm"))'.dependencies]
+secp256k1 = { version = "0.24.3", default-features = false, features = ["std","serde", "recovery"] }
 rusqlite = { workspace = true, optional = true }
 
+[target.'cfg(target_family = "wasm")'.dependencies]
+libsecp256k1 = { version = "0.7.2", default-features = false, features = ["hmac", "lazy-static-context"] }
+
 [target.'cfg(all(any(target_arch = "x86_64", target_arch = "x86", target_arch = "aarch64"), not(any(target_os="windows"))))'.dependencies]
 sha2 = { version = "0.10", features = ["asm"] }
 

stacks-common/Cargo.toml

@@ -69,6 +69,12 @@ pub trait PublicKey: Clone + fmt::Debug + serde::Serialize + serde::de::Deserial
 pub trait PrivateKey: Clone + fmt::Debug + serde::Serialize + serde::de::DeserializeOwned {
     fn to_bytes(&self) -> Vec<u8>;
     fn sign(&self, data_hash: &[u8]) -> Result<MessageSignature, &'static str>;
+    #[cfg(any(test, feature = "testing"))]
+    fn sign_with_noncedata(
+        &self,
+        data_hash: &[u8],
+        noncedata: &[u8; 32],
+    ) -> Result<MessageSignature, &'static str>;
 }
 
 pub trait Address: Clone + fmt::Debug + fmt::Display {