Skip to content

Commit 1c3cfc8

Browse files
varunu28mhalbritter
authored andcommitted
Fix compose file generation for empty services
See gh-1735 Signed-off-by: varunu28 <varun.u28@gmail.com>
1 parent 7cb96d5 commit 1c3cfc8

File tree

2 files changed

+12
-0
lines changed

2 files changed

+12
-0
lines changed

initializr-generator/src/main/java/io/spring/initializr/generator/container/docker/compose/ComposeFileWriter.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,10 @@ public class ComposeFileWriter {
4040
* @param compose the compose file to write
4141
*/
4242
public void writeTo(IndentingWriter writer, ComposeFile compose) {
43+
if (compose.services().isEmpty()) {
44+
writer.println("services: {}");
45+
return;
46+
}
4347
writer.println("services:");
4448
compose.services()
4549
.values()

initializr-generator/src/test/java/io/spring/initializr/generator/container/docker/compose/ComposeFileWriterTests.java

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -91,6 +91,14 @@ void servicesAreOrderedByName() {
9191
""");
9292
}
9393

94+
@Test
95+
void servicesWithNoEntriesWrittenAsEmptyMap() {
96+
ComposeFile file = new ComposeFile();
97+
assertThat(write(file)).isEqualToIgnoringNewLines("""
98+
services: {}
99+
""");
100+
}
101+
94102
private Consumer<Builder> withSuffix(int suffix) {
95103
return (builder) -> builder.image("image-" + suffix).imageTag("image-tag-" + suffix);
96104
}

0 commit comments

Comments
 (0)