From a3e197cec2bcadeec6da49c0552e7d78e12230f1 Mon Sep 17 00:00:00 2001
From: Danagul Otel <danao@spotify.com>
Date: Wed, 8 Jan 2025 12:21:43 +0100
Subject: [PATCH] Do not retry on 404 error code

---
 Sources/SPTDataLoader/SPTDataLoaderResponse.m             | 2 +-
 Tests/SPTDataLoader/SPTDataLoaderRequestTaskHandlerTest.m | 2 +-
 Tests/SPTDataLoader/SPTDataLoaderResponseTest.m           | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/Sources/SPTDataLoader/SPTDataLoaderResponse.m b/Sources/SPTDataLoader/SPTDataLoaderResponse.m
index 89a40ac..609c530 100644
--- a/Sources/SPTDataLoader/SPTDataLoaderResponse.m
+++ b/Sources/SPTDataLoader/SPTDataLoaderResponse.m
@@ -106,8 +106,8 @@ - (BOOL)shouldRetry
             case SPTDataLoaderResponseHTTPStatusCodeExpectationFail:
             case SPTDataLoaderResponseHTTPStatusCodeHTTPVersionNotSupported:
             case SPTDataLoaderResponseHTTPStatusCodeNotImplemented:
-                return NO;
             case SPTDataLoaderResponseHTTPStatusCodeNotFound:
+                return NO;
             case SPTDataLoaderResponseHTTPStatusCodeRequestTimeout:
             case SPTDataLoaderResponseHTTPStatusCodeUnsupportedMediaTypes:
             case SPTDataLoaderResponseHTTPStatusCodeInternalServerError:
diff --git a/Tests/SPTDataLoader/SPTDataLoaderRequestTaskHandlerTest.m b/Tests/SPTDataLoader/SPTDataLoaderRequestTaskHandlerTest.m
index 64f140e..50fba76 100644
--- a/Tests/SPTDataLoader/SPTDataLoaderRequestTaskHandlerTest.m
+++ b/Tests/SPTDataLoader/SPTDataLoaderRequestTaskHandlerTest.m
@@ -125,7 +125,7 @@ - (void)testRetry
     [self.handler receiveResponse:httpResponse];
     [self.handler completeWithError:nil];
     XCTAssertEqual(self.requestResponseHandler.numberOfSuccessfulDataResponseCalls, 0u, @"The handler did relay a successful response onto its request response handler when it should have silently retried");
-    XCTAssertEqual(self.requestResponseHandler.numberOfFailedResponseCalls, 0u, @"The handler did relay a failed response onto its request response handler when it should have silently retried");
+    XCTAssertEqual(self.requestResponseHandler.numberOfFailedResponseCalls, 1u, @"The handler did not relay a failed response onto its request response handler for a 404 status code");
 }
 
 - (void)testRetryWithResponseBody
diff --git a/Tests/SPTDataLoader/SPTDataLoaderResponseTest.m b/Tests/SPTDataLoader/SPTDataLoaderResponseTest.m
index b4d6885..63e75ba 100644
--- a/Tests/SPTDataLoader/SPTDataLoaderResponseTest.m
+++ b/Tests/SPTDataLoader/SPTDataLoaderResponseTest.m
@@ -69,7 +69,7 @@ - (void)testShouldRetryWithNotFoundHTTPStatusCode
                                                  headerFields:nil];
     self.response = [SPTDataLoaderResponse dataLoaderResponseWithRequest:self.request response:self.urlResponse];
     BOOL shouldRetry = [self.response shouldRetry];
-    XCTAssertTrue(shouldRetry, @"The response should retry when given the HTTP status code of Not Found");
+    XCTAssertFalse(shouldRetry, @"The response should not retry when given the HTTP status code of Not Found");
 }
 
 - (void)testShouldRetryForCertificateRejection