From 5cedbab09dc84d5f5e58f8237d6c5ca0867c86d2 Mon Sep 17 00:00:00 2001 From: skyflow-bharti Date: Fri, 13 Feb 2026 14:53:43 +0530 Subject: [PATCH 1/2] SK-2548 update config validation --- skyflow/error/_skyflow_error.py | 1 - skyflow/utils/_skyflow_messages.py | 4 ++-- skyflow/utils/_utils.py | 4 ++-- 3 files changed, 4 insertions(+), 5 deletions(-) diff --git a/skyflow/error/_skyflow_error.py b/skyflow/error/_skyflow_error.py index 7b917fae..fca43935 100644 --- a/skyflow/error/_skyflow_error.py +++ b/skyflow/error/_skyflow_error.py @@ -15,5 +15,4 @@ def __init__(self, self.http_status = http_status if http_status else SkyflowMessages.HttpStatus.BAD_REQUEST.value self.details = details self.request_id = request_id - log_error(message, http_code, request_id, grpc_code, http_status, details) super().__init__() \ No newline at end of file diff --git a/skyflow/utils/_skyflow_messages.py b/skyflow/utils/_skyflow_messages.py index 6a31c078..ab2da94b 100644 --- a/skyflow/utils/_skyflow_messages.py +++ b/skyflow/utils/_skyflow_messages.py @@ -16,7 +16,7 @@ class ErrorCodes(Enum): REDACTION_WITH_TOKENS_NOT_SUPPORTED = 400 class Error(Enum): - GENERIC_API_ERROR = f"{error_prefix} Validation error. Invalid configuration. Please add a valid vault configuration." + GENERIC_API_ERROR = f"{error_prefix} API error. Error occurred." EMPTY_VAULT_ID = f"{error_prefix} Initialization failed. Invalid vault Id. Specify a valid vault Id." INVALID_VAULT_ID = f"{error_prefix} Initialization failed. Invalid vault Id. Specify a valid vault Id as a string." @@ -283,7 +283,6 @@ class Info(Enum): VALIDATING_FILE_UPLOAD_REQUEST = f"{INFO}: [{error_prefix}] Validating file upload request." FILE_UPLOAD_REQUEST_RESOLVED = f"{INFO}: [{error_prefix}] File upload request resolved." FILE_UPLOAD_SUCCESS = f"{INFO}: [{error_prefix}] File uploaded successfully." - FILE_UPLOAD_REQUEST_REJECTED = f"{ERROR}: [{error_prefix}] File upload failed." INVOKE_CONNECTION_TRIGGERED = f"{INFO}: [{error_prefix}] Invoke connection method triggered." VALIDATING_INVOKE_CONNECTION_REQUEST = f"{INFO}: [{error_prefix}] Validating invoke connection request." @@ -351,6 +350,7 @@ class ErrorLogs(Enum): EMPTY_OR_NULL_VALUE_IN_TOKENS = f"{ERROR}: [{error_prefix}] Invalid {{}} request. Value can not be null or empty in tokens for key {{}}." EMPTY_OR_NULL_KEY_IN_TOKENS = f"{ERROR}: [{error_prefix}] Invalid {{}} request. Key can not be null or empty in tokens." MISMATCH_OF_FIELDS_AND_TOKENS = f"{ERROR}: [{error_prefix}] Invalid {{}} request. Keys for values and tokens are not matching." + FILE_UPLOAD_REQUEST_REJECTED = f"{ERROR}: [{error_prefix}] File upload failed." EMPTY_IDS = f"{ERROR}: [{error_prefix}] Invalid {{}} request. Ids can not be empty." EMPTY_OR_NULL_ID_IN_IDS = f"{ERROR}: [{error_prefix}] Invalid {{}} request. Id can not be null or empty in ids at index {{}}." diff --git a/skyflow/utils/_utils.py b/skyflow/utils/_utils.py index 567227f7..5d83cbcc 100644 --- a/skyflow/utils/_utils.py +++ b/skyflow/utils/_utils.py @@ -461,7 +461,7 @@ def log_and_reject_error(description, status_code, request_id, http_status=None, def handle_exception(error, logger): if isinstance(error, httpx.ConnectError): - description = SkyflowMessages.Error.GENERIC_API_ERROR.value + description = str(error) if error else SkyflowMessages.Error.GENERIC_API_ERROR.value log_and_reject_error(description, SkyflowMessages.ErrorCodes.INVALID_INPUT.value, None, logger=logger) return @@ -506,7 +506,7 @@ def handle_text_error(err, data, request_id, logger): log_and_reject_error(data, err.status, request_id, logger = logger) def handle_generic_error_with_status(err, request_id, status, logger): - description = SkyflowMessages.Error.GENERIC_API_ERROR.value + description = str(err) if err else SkyflowMessages.Error.GENERIC_API_ERROR.value log_and_reject_error(description, status, request_id, logger=logger) def encode_column_values(get_request): From 7d29262445d4e6386c8870433432de4d376dcfcb Mon Sep 17 00:00:00 2001 From: skyflow-bharti Date: Fri, 13 Feb 2026 16:25:43 +0530 Subject: [PATCH 2/2] SK-2548 fix the unit test cases --- tests/utils/test__utils.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/utils/test__utils.py b/tests/utils/test__utils.py index 09195b89..a0c9e3b2 100644 --- a/tests/utils/test__utils.py +++ b/tests/utils/test__utils.py @@ -615,7 +615,7 @@ def test_handle_exception_connect_error(self, mock_log_and_reject_error): handle_exception(mock_error, mock_logger) mock_log_and_reject_error.assert_called_once_with( - SkyflowMessages.Error.GENERIC_API_ERROR.value, + 'Connection refused', SkyflowMessages.ErrorCodes.INVALID_INPUT.value, None, logger=mock_logger @@ -688,7 +688,7 @@ def test_handle_exception_generic_error_with_status(self, mock_log_and_reject_er handle_exception(mock_error, mock_logger) mock_log_and_reject_error.assert_called_once_with( - SkyflowMessages.Error.GENERIC_API_ERROR.value, + str(mock_error), 503, "1234", logger=mock_logger @@ -706,7 +706,7 @@ def test_handle_exception_no_content_type(self, mock_log_and_reject_error): handle_exception(mock_error, mock_logger) mock_log_and_reject_error.assert_called_once_with( - SkyflowMessages.Error.GENERIC_API_ERROR.value, + str(mock_error), 500, "1234", logger=mock_logger @@ -812,7 +812,7 @@ def test_handle_generic_error_with_status(self, mock_log_and_reject_error): handle_generic_error_with_status(mock_error, request_id, status, mock_logger) mock_log_and_reject_error.assert_called_once_with( - SkyflowMessages.Error.GENERIC_API_ERROR.value, + str(mock_error), 503, request_id, logger=mock_logger