Merge pull request #69 from sillsdev/DirectNotionVideos

feat: Handle direct Notion videos (#65)

Author: andrew-polk

src/plugins/VideoTransformer.spec.ts

@@ -85,3 +85,31 @@ test("video link, not embedded", async () => {
   );
   expect(result).not.toContain(`import`);
 });
+
+test("direct upload to to Notion (embedded)", async () => {
+  setLogLevel("verbose");
+  const config = { plugins: [standardVideoTransformer] };
+  const result = await blocksToMarkdown(config, [
+    {
+      object: "block",
+      id: "12f7db3b-4412-4be9-a3f7-6ac423fee94a",
+      parent: {
+        type: "page_id",
+        page_id: "edaffeb2-ece8-4d44-976f-351e6b5757bb",
+      },
+
+      type: "video",
+      video: {
+        caption: [],
+        type: "file",
+        file: {
+          url: "https://s3.us-west-2.amazonaws.com/secure.notion-static.com/f6bc4746-011e-2124-86ca-ed4337d70891/people_fre_motionAsset_p3.mp4?X-Blah-blah",
+        },
+      },
+    } as unknown as NotionBlock,
+  ]);
+  expect(result).toContain(`import ReactPlayer from "react-player";`);
+  expect(result).toContain(
+    `<ReactPlayer controls url="https://s3.us-west-2.amazonaws.com/secure.notion-static.com/f6bc4746-011e-2124-86ca-ed4337d70891/people_fre_motionAsset_p3.mp4?X-Blah-blah" />`
+  );
+});

src/plugins/VideoTransformer.ts

@@ -13,16 +13,24 @@ export const standardVideoTransformer: IPlugin = {
         block: NotionBlock
       ): string => {
         const video = (block as VideoBlockObjectResponse).video;
-        if (video.type === "external") {
-          if (!context.imports) context.imports = [];
-          context.imports.push(`import ReactPlayer from "react-player";`);
-          return `<ReactPlayer controls url="${video.external.url}" />`;
-        } else {
-          warning(
-            `[standardVideoTransformer] Found Notion "video" block with type ${video.type}. The best docu-notion can do for now is ignore it.`
-          );
+        let url = "";
+        switch (video.type) {
+          case "external":
+            url = video.external.url;
+            break;
+          case "file":
+            url = video.file.url;
+            break;
+          default:
+            warning(
+              `[standardVideoTransformer] Found Notion "video" block with type ${video.type}. The best docu-notion can do for now is ignore it.`
+            );
+            return "";
+            break;
         }
-        return "";
+
+        context.imports.push(`import ReactPlayer from "react-player";`);
+        return `<ReactPlayer controls url="${url}" />`;
       },
     },
   ],

src/plugins/pluginTestRun.ts

@@ -36,6 +36,7 @@ export async function blocksToMarkdown(
     convertNotionLinkToLocalDocusaurusLink: (url: string) => {
       return convertInternalUrl(docunotionContext, url);
     },
+    imports: [],
 
     //TODO might be needed for some tests, e.g. the image transformer...
     directoryContainingMarkdown: "not yet",

src/plugins/pluginTypes.ts

@@ -80,5 +80,5 @@ export type IDocuNotionContext = {
   // If the output is creating things like react elements, you can append their import definitions
   // to this array so they get added to the page.
   // e.g. context.imports.push(`import ReactPlayer from "react-player";`);
-  imports?: string[];
+  imports: string[];
 };

src/pull.ts

@@ -111,6 +111,7 @@ async function outputPages(
     options: options,
     pages: pages,
     counts: counts, // review will this get copied or pointed to?
+    imports: [],
     convertNotionLinkToLocalDocusaurusLink: (url: string) =>
       convertInternalUrl(context, url),
   };