hsflowd.spec Missing Require

[bnerickson]

OS: Rocky Linux 10.1
Kernel: 6.12.0-124.31.1.el10_1.x86_64
hsflowd: hsflowd-2.1.21-1.el10.x86_64

The hsflowd.spec currently doesn't require the chkconfig package, but installs /etc/init.d/hsflowd anyway. On RHEL10 systems, chkconfig is not installed as part of the base install. If the administrator attempts to install chkconfig after hsflowd has been installed, or another package requires chkconfig after hsflowd has been installed, then the chkconfig install will fail with the following errors:

["error: unpacking of archive failed on file /etc/init.d;698d1351: cpio: File from package already exists as a directory in system", "error: chkconfig-1.30-2.el10.x86_64: install failed", "Created symlink '/etc/systemd/system/sysinit.target.wants/import-state.service' → '/usr/lib/systemd/system/import-state.service'."]

The fix should be relatively straightforward; add the following line to hsflowd.spec:

Requires: chkconfig

I can submit a PR to fix, but maybe the solution is to rip /etc/init.d/hsflowd out of there entirely. I'm not sure if there are any rpm-based distros out there not using systemd.

[sflow]

Thanks. I agree that it should come out altogether now.

[bnerickson]

@sflow do you mean that the init.d instructions for all builds should be removed, or just redhat? Here's a hacky patch to fix the spec which would only affect builds using hsflowd.spec:

@@ -48,6 +48,7 @@ make FEATURES=%{_FEATURES}
 %install
 rm -rf %{buildroot}
 make INSTROOT=%{buildroot} FEATURES=%{_FEATURES} install
+rm -f ${buildroot}/etc/init.d/hsflowd
 
 %clean
 rm -rf %{buildroot}
@@ -58,7 +59,6 @@ make clean
 /usr/sbin/hsflowd*
 %config(noreplace) /etc/hsflowd.conf
 %config(noreplace) /etc/dbus-1/system.d/net.sflow.hsflowd.conf
-/etc/init.d/hsflowd
 /lib/systemd/system/hsflowd.service
 %doc README LICENSE INSTALL.Linux
 /etc/hsflowd/modules/