Commit facabc5
committed
cqlengine: Remove deepcopy on UserType deserialization
This change makes it so newly instanced UserType during deserialization
isn't immediately copied by deepcopy, which could cause huge slowdown if
that UserType contains a lot of data or nested UserTypes, in which case the
deepcopy calls would cascade as each to_python call would eventually clone
parts of source object. As there isn't a lot of information on why this
deepcopy is here in the first place this change could potentially break
something. Running integration tests against this commit does not produce
regressions, so this call looks safe to remove, but I'm leaving this
warning here for the future reference.
Fixes #1521 parent 679ad24 commit facabc5
1 file changed
+3
-4
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1038 | 1038 | | |
1039 | 1039 | | |
1040 | 1040 | | |
1041 | | - | |
1042 | 1041 | | |
1043 | | - | |
1044 | | - | |
| 1042 | + | |
| 1043 | + | |
1045 | 1044 | | |
1046 | | - | |
| 1045 | + | |
1047 | 1046 | | |
1048 | 1047 | | |
1049 | 1048 | | |
| |||
0 commit comments