fix FRED and QtFRED handling of waypoint names

First, fix a crash reported in Discord: prevent FRED or QtFRED from giving a waypoint list a name that is too long.

Also fix the updating of references, including for the constituent points, if a waypoint list is renamed.

Author: Goober5000

code/object/waypoint.cpp

@@ -127,8 +127,14 @@ SCP_vector<waypoint> &waypoint_list::get_waypoints()
 
 void waypoint_list::set_name(const char *name)
 {
-	Assert(name != NULL);
-	strcpy_s(this->m_name, name);
+	Assertion(name != nullptr, "Waypoint name cannot be null!");
+
+	auto len = strlen(name);
+	if (len >= NAME_LENGTH)
+		len = NAME_LENGTH - 5;	// leave room for a colon, three digits, and a null terminator for points that belong to this list
+
+	strncpy(this->m_name, name, len);
+	this->m_name[len] = '\0';
 }
 
 //********************FUNCTIONS********************

fred2/waypointpathdlg.cpp

@@ -265,15 +265,22 @@ int waypoint_path_dlg::update_data(int redraw)
 
 
 		strcpy_s(old_name, cur_waypoint_list->get_name());
-		str = (char *) (LPCTSTR) m_name;
-		cur_waypoint_list->set_name(str);
+		cur_waypoint_list->set_name((LPCTSTR) m_name);
+		str = cur_waypoint_list->get_name();
 		if (strcmp(old_name, str)) {
 			set_modified(TRUE);
 			update_sexp_references(old_name, str);
-			ai_update_goal_references(sexp_ref_type::WAYPOINT, old_name, str);
-			update_texture_replacements(old_name, str);
+			ai_update_goal_references(sexp_ref_type::WAYPOINT_PATH, old_name, str);
+
+			for (auto &wpt: cur_waypoint_list->get_waypoints()) {
+				char old_buf[NAME_LENGTH + 8];
+				char new_buf[NAME_LENGTH + 8];
+				sprintf(old_buf, "%s:%d", old_name, wpt.get_index() + 1);
+				sprintf(new_buf, "%s:%d", str, wpt.get_index() + 1);
+				update_sexp_references(old_buf, new_buf);
+				ai_update_goal_references(sexp_ref_type::WAYPOINT, old_buf, new_buf);
+			}
 		}
-
 	}
 
 	if (redraw)

qtfred/src/mission/dialogs/WaypointEditorDialogModel.cpp

@@ -24,15 +24,23 @@ bool WaypointEditorDialogModel::apply()
 	// apply name
 	char old_name[255];
 	strcpy_s(old_name, _editor->cur_waypoint_list->get_name());
-	const char* str = _currentName.c_str();
-	_editor->cur_waypoint_list->set_name(str);
+	_editor->cur_waypoint_list->set_name(_currentName.c_str());
+	auto str = _editor->cur_waypoint_list->get_name();
 	if (strcmp(old_name, str) != 0) {
+		_editor->missionChanged();
 		update_sexp_references(old_name, str);
-		_editor->ai_update_goal_references(sexp_ref_type::WAYPOINT, old_name, str);
-		_editor->update_texture_replacements(old_name, str); // ?? Uh really? Check that FRED does this also
+		_editor->ai_update_goal_references(sexp_ref_type::WAYPOINT_PATH, old_name, str);
+
+		for (auto &wpt : _editor->cur_waypoint_list->get_waypoints()) {
+			char old_buf[NAME_LENGTH + 8];
+			char new_buf[NAME_LENGTH + 8];
+			sprintf(old_buf, "%s:%d", old_name, wpt.get_index() + 1);
+			sprintf(new_buf, "%s:%d", str, wpt.get_index() + 1);
+			update_sexp_references(old_buf, new_buf);
+			_editor->ai_update_goal_references(sexp_ref_type::WAYPOINT, old_buf, new_buf);
+		}
 	}
 
-	_editor->missionChanged();
 	return true;
 }