Fix a return of a unique pointer

djw8605 · djw8605 · commit c47b114c3670 · 2023-04-25T19:37:05.000-05:00
diff --git a/src/scitokens_internal.cpp b/src/scitokens_internal.cpp
@@ -638,7 +638,7 @@ std::unique_ptr<AsyncStatus> Validator::get_public_keys_from_web_continue(
                 cget_status =
                     status->m_cget->perform_start(status->m_oauth_metadata_url);
                 if (!cget_status.m_done) {
-                    return status;
+                    return std::move(status);
                 }
                 return get_public_keys_from_web_continue(std::move(status));
             }

Original file line number	Diff line number	Diff line change
`@@ -638,7 +638,7 @@ std::unique_ptr<AsyncStatus> Validator::get_public_keys_from_web_continue(`
`638`	`638`	`cget_status =`
`639`	`639`	`status->m_cget->perform_start(status->m_oauth_metadata_url);`
`640`	`640`	`if (!cget_status.m_done) {`
`641`		`- return status;`
	`641`	`+ return std::move(status);`
`642`	`642`	`}`
`643`	`643`	`return get_public_keys_from_web_continue(std::move(status));`
`644`	`644`	`}`