`isDev` in webpack.config.js always truthy

[prohazko2]

Hi, noticed some kind of bug in webpack.config file
https://github.com/schrodinger/fixed-data-table-2/blob/master/webpack.config.js#L9

var isDev = JSON.stringify(process.env.NODE_ENV !== 'production');

isDev always evaluates to truthy string value after json stringification, so webpack always works in development mode, even for build-dist npm script here
https://github.com/schrodinger/fixed-data-table-2/blob/master/webpack.config.js#L62

Maybe something like

mode: isDev === 'true' ? 'development' : 'production',

would be better?

[pradeepnschrodinger]

Good catch. Could you put up a PR?

And could you also check if we need the same fix in these config files as well?:

• https://github.com/schrodinger/fixed-data-table-2/blob/master/webpack.config-test.js
• https://github.com/schrodinger/fixed-data-table-2/blob/master/site/webpack-prerender.config.js
• https://github.com/schrodinger/fixed-data-table-2/blob/master/site/webpack-client.config.js

[prohazko2]

Yeah, sure. Give me couple days

[wcjordan]

Since there hasn't been anything new here, I'm going to tag it for the backlog since we're considering redo-ing the build system before too long.