replace fmt.Sprintf(err) by err.Error()

Author: Mia-Cross

internal/services/instance/action_create_snapshot.go

@@ -162,7 +162,7 @@ func (c *CreateSnapshot) Invoke(ctx context.Context, req action.InvokeRequest, r
 		if err != nil {
 			resp.Diagnostics.AddError(
 				"error creating instance snapshot",
-				fmt.Sprintf("%s", err))
+				err.Error())
 
 			return
 		}
@@ -175,7 +175,7 @@ func (c *CreateSnapshot) Invoke(ctx context.Context, req action.InvokeRequest, r
 			if errWait != nil {
 				resp.Diagnostics.AddError(
 					"error waiting for instance snapshot",
-					fmt.Sprintf("%s", err))
+					err.Error())
 			}
 		}
 	case instance.VolumeVolumeTypeSbsVolume:
@@ -205,7 +205,7 @@ func (c *CreateSnapshot) Invoke(ctx context.Context, req action.InvokeRequest, r
 		if err != nil {
 			resp.Diagnostics.AddError(
 				"error creating block snapshot",
-				fmt.Sprintf("%s", err))
+				err.Error())
 
 			return
 		}
@@ -218,7 +218,7 @@ func (c *CreateSnapshot) Invoke(ctx context.Context, req action.InvokeRequest, r
 			if errWait != nil {
 				resp.Diagnostics.AddError(
 					"error waiting for block snapshot",
-					fmt.Sprintf("%s", err))
+					err.Error())
 			}
 		}
 	case instance.VolumeVolumeTypeScratch:

internal/services/instance/action_export_snapshot.go

@@ -150,7 +150,7 @@ func (e *ExportSnapshot) Invoke(ctx context.Context, req action.InvokeRequest, r
 		if err != nil {
 			resp.Diagnostics.AddError(
 				"error exporting instance snapshot",
-				fmt.Sprintf("%s", err))
+				err.Error())
 
 			return
 		}
@@ -163,7 +163,7 @@ func (e *ExportSnapshot) Invoke(ctx context.Context, req action.InvokeRequest, r
 			if err != nil {
 				resp.Diagnostics.AddError(
 					"error waiting for instance snapshot",
-					fmt.Sprintf("%s", err))
+					err.Error())
 			}
 		}
 	case instance.VolumeVolumeTypeSbsSnapshot:
@@ -183,7 +183,7 @@ func (e *ExportSnapshot) Invoke(ctx context.Context, req action.InvokeRequest, r
 		if err != nil {
 			resp.Diagnostics.AddError(
 				"error exporting block snapshot",
-				fmt.Sprintf("%s", err))
+				err.Error())
 
 			return
 		}
@@ -196,7 +196,7 @@ func (e *ExportSnapshot) Invoke(ctx context.Context, req action.InvokeRequest, r
 			if err != nil {
 				resp.Diagnostics.AddError(
 					"error waiting for block snapshot",
-					fmt.Sprintf("%s", err))
+					err.Error())
 			}
 		}
 	default:

internal/services/instance/action_server_action.go

@@ -136,20 +136,20 @@ func (a *ServerAction) Invoke(ctx context.Context, req action.InvokeRequest, res
 	if err != nil {
 		resp.Diagnostics.AddError(
 			"error in server action",
-			fmt.Sprintf("%s", err))
+			err.Error())
 
 		return
 	}
 
 	if data.Wait.ValueBool() {
-		_, errWait := a.instanceAPI.WaitForServer(&instance.WaitForServerRequest{
+		server, err := a.instanceAPI.WaitForServer(&instance.WaitForServerRequest{
 			ServerID: serverID,
 			Zone:     scw.Zone(zone),
 		}, scw.WithContext(ctx))
-		if errWait != nil && data.Action.ValueString() != instance.ServerActionTerminate.String() {
+		if err != nil && data.Action.ValueString() != instance.ServerActionTerminate.String() {
 			resp.Diagnostics.AddError(
-				"error in wait server",
-				fmt.Sprintf("%s", err))
+				"error waiting for server"+serverID,
+				err.Error())
 		}
 	}
 }