Optimization: Introduce CompactAnnotation #24679
Open
+255
−155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odersky
force-pushed
the
opt-annots
branch
3 times, most recently
from
9af8000 to
66aa6bb
Compare
This one takes a type argument instead of as a tree argument. For now it's reserved for retains-like annotations. CompactAnnotations don't need tree maps and annotated types containing them hash properly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one takes a type argument instead of as a tree argument. This makes mapping such annotations a lot faster and also safer. In fact, in retrospect, most annotations could be represented as
CompactAnnotations.CompactAnnotationis extended byRetainingAnnotation, which is reserved for@retains,@retainsByNameand@retainsCap. We make sure that all annotations with these classes are represented asRetainingAnnotations.For now there are no
CompactAnnotations other than@RetainingAnnotations but this could be changed in the future.