Skip to content

Commit f49cb45

Browse files
committed
fix: variable casing
1 parent 0cc3f24 commit f49cb45

File tree

2 files changed

+4
-11
lines changed

2 files changed

+4
-11
lines changed

sync-team/src/github/api/mod.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -503,7 +503,7 @@ pub(crate) enum RulesetTarget {
503503
}
504504

505505
#[derive(Clone, Debug, PartialEq, Eq, serde::Serialize, serde::Deserialize)]
506-
#[serde(rename_all = "lowercase")]
506+
#[serde(rename_all = "PascalCase")]
507507
pub(crate) enum RulesetSourceType {
508508
Repository,
509509
Organization,

sync-team/src/github/api/read.rs

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -551,23 +551,16 @@ impl GithubRead for GitHubApiRead {
551551
org: &str,
552552
repo: &str,
553553
) -> anyhow::Result<Vec<crate::github::api::Ruleset>> {
554-
#[derive(serde::Deserialize)]
555-
struct RulesetsResponse {
556-
#[serde(default)]
557-
rulesets: Vec<Ruleset>,
558-
}
559-
560554
let mut rulesets: Vec<Ruleset> = Vec::new();
561555

562556
// REST API endpoint for rulesets
563557
// https://docs.github.com/en/rest/repos/rules#get-all-repository-rulesets
558+
// The API returns an array of rulesets directly, not wrapped in an object
564559
self.client.rest_paginated(
565560
&Method::GET,
566561
&GitHubUrl::repos(org, repo, "rulesets")?,
567-
|resp: RulesetsResponse| {
568-
for ruleset in resp.rulesets {
569-
rulesets.push(ruleset);
570-
}
562+
|resp: Vec<Ruleset>| {
563+
rulesets.extend(resp);
571564
Ok(())
572565
},
573566
)?;

0 commit comments

Comments
 (0)