Skip to content

fix: compile failure that Deflate is ambiguous #516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Byron merged 2 commits into from
Dec 5, 2025
Merged

fix: compile failure that Deflate is ambiguous #516

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a6ca2a
fix: compile failure that Deflate is ambiguous
Xuanwo Dec 5, 2025
389af1f
Bump version
Xuanwo Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
[package]
name = "flate2"
authors = ["Alex Crichton <alex@alexcrichton.com>", "Josh Triplett <josh@joshtriplett.org>"]
version = "1.1.6"
version = "1.1.7"
edition = "2018"
license = "MIT OR Apache-2.0"
readme = "README.md"
Expand Down
22 changes: 20 additions & 2 deletions src/ffi/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,16 +65,34 @@ mod c;
#[cfg(feature = "any_zlib")]
pub use self::c::*;

// Prefer zlib-rs when both Rust backends are enabled to avoid duplicate exports.
#[cfg(all(not(feature = "any_zlib"), feature = "zlib-rs"))]
mod zlib_rs;
#[cfg(all(not(feature = "any_zlib"), feature = "zlib-rs"))]
pub use self::zlib_rs::*;

#[cfg(all(not(feature = "any_zlib"), feature = "miniz_oxide"))]
// Fallback to miniz_oxide when zlib-rs is not selected.
#[cfg(all(
not(feature = "any_zlib"),
not(feature = "zlib-rs"),
feature = "miniz_oxide"
))]
mod miniz_oxide;
#[cfg(all(not(feature = "any_zlib"), feature = "miniz_oxide"))]
#[cfg(all(
not(feature = "any_zlib"),
not(feature = "zlib-rs"),
feature = "miniz_oxide"
))]
pub use self::miniz_oxide::*;

// If no backend is enabled, fail fast with a clear error message.
#[cfg(all(
not(feature = "any_zlib"),
not(feature = "zlib-rs"),
not(feature = "miniz_oxide")
))]
compile_error!("No compression backend selected; enable one of `zlib`, `zlib-ng`, `zlib-rs`, or the default `rust_backend` feature.");
Copy link
Contributor Author

@Xuanwo Xuanwo Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This branch added for better UE, I'm open to just remove it.


impl std::fmt::Debug for ErrorMessage {
fn fmt(&self, f: &mut std::fmt::Formatter) -> std::fmt::Result {
self.get().fmt(f)
Expand Down