Refactor test setup to use PathSubstitution for file paths #2789
+16
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s2_control_node_launch.py
github-actions
bot
requested review from
aprotyas,
arne48,
christophfroehlich,
destogl,
homalozoa,
moriarty and
qiayuanl
christophfroehlich
requested changes
Nov 13, 2025
Member
christophfroehlich
left a comment
christophfroehlich
left a comment
There was a problem hiding this comment.
Please consider my comments in https://github.com/ros-controls/ros2_control/pull/2781/files
Member
|
@shrujanus I've ran the tests after updating the branch. @christophfroehlich 's comments are spot on. Please address the current CI failures. |
Author
|
bmagyar Thanks for the reply! Is there a way to test the CI locally? I've made the changes and wanted to test them before updating the branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored the ./controller_manager/test/test_ros2_control_node_launch.py file to use PathSubstitution and removed the unnecessary variables in the import.