Skip to content

Commit 32f8176

Browse files
author
Takashi Kato
committed
Fix rubocop warning
1 parent 7c67f54 commit 32f8176

File tree

12 files changed

+66
-48
lines changed

12 files changed

+66
-48
lines changed

.rubocop.yml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
Naming/FileName:
2+
Enabled: false
3+
Documentation:
4+
Enabled: false
5+
Style/FrozenStringLiteralComment:
6+
Enabled: false
7+
8+

Gemfile

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
1-
source "https://rubygems.org"
1+
source 'https://rubygems.org'
22
git_source(:github) { |repo| "https://github.com/#{repo}.git" }
33

44
# Specify your gem's dependencies in importmap_mocha-rails.gemspec.
55
gemspec
6+

Rakefile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
1-
require "bundler/setup"
1+
require 'bundler/setup'
22

3-
require "bundler/gem_tasks"
3+
require 'bundler/gem_tasks'
Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,9 @@
1-
class ImportmapMocha::TestController < ActionController::Base
2-
layout false
1+
# frozen_string_literal: true
32

4-
def index
3+
module ImportmapMocha
4+
class TestController < ActionController::Base
5+
layout false
6+
7+
def index; end
58
end
69
end
Lines changed: 15 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,19 @@
1-
module ImportmapMocha::TestHelper
2-
def testcase
3-
files.map{|m| javascript_import_module_tag(m.to_s.sub('.js', '')) }.join("\n").html_safe
4-
end
1+
# frozen_string_literal: true
52

6-
def files
7-
root_path.flat_map{|path| path.glob('**/*.js').map{|m| m.relative_path_from(path)}}
8-
end
3+
module ImportmapMocha
4+
module TestHelper
5+
PATTERN = ['**/*.test.js', '**/*.spec.js'].freeze
6+
7+
def testcase
8+
files.map { |m| javascript_import_module_tag(m.to_s.sub('.js', '')) }.join("\n").html_safe
9+
end
10+
11+
def files
12+
root_path.flat_map { |path| path.glob(PATTERN).map { |m| m.relative_path_from(path) } }
13+
end
914

10-
def root_path
11-
Rails.application.config.importmap_mocha_path
15+
def root_path
16+
Rails.application.config.importmap_mocha_path
17+
end
1218
end
1319
end

bin/test

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
#!/usr/bin/env ruby
2-
$: << File.expand_path("../test", __dir__)
2+
$LOAD_PATH << File.expand_path('../test', __dir__)
33

4-
require "bundler/setup"
5-
require "rails/plugin/test"
4+
require 'bundler/setup'
5+
require 'rails/plugin/test'

config/importmap.rb

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,3 @@
22
Rails.application.config.importmap_mocha_path.each do |path|
33
pin_all_from path
44
end
5-

importmap_mocha-rails.gemspec

Lines changed: 13 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,22 @@
1-
require_relative "lib/importmap_mocha/version"
1+
require_relative 'lib/importmap_mocha/version'
22

33
Gem::Specification.new do |spec|
4-
spec.name = "importmap_mocha-rails"
4+
spec.name = 'importmap_mocha-rails'
55
spec.version = ImportmapMocha::VERSION
6-
spec.authors = ["Takashi Kato"]
7-
spec.email = ["tohosaku@users.osdn.me"]
8-
spec.homepage = "https://github.com/tohosaku/importmap_mocha-rails"
9-
spec.summary = "Add JavaScript testing tools in importmap environment."
10-
spec.description = "Add JavaScript testing tools in importmap environment."
6+
spec.authors = ['Takashi Kato']
7+
spec.email = ['tohosaku@users.osdn.me']
8+
spec.homepage = 'https://github.com/tohosaku/importmap_mocha-rails'
9+
spec.summary = 'Add JavaScript testing tools in importmap environment.'
10+
spec.description = 'Add JavaScript testing tools in importmap environment.'
11+
spec.required_ruby_version = '>= 2.7.0'
1112

12-
spec.metadata["homepage_uri"] = spec.homepage
13-
spec.metadata["source_code_uri"] = spec.homepage
14-
spec.metadata["changelog_uri"] = spec.homepage
13+
spec.metadata['homepage_uri'] = spec.homepage
14+
spec.metadata['source_code_uri'] = spec.homepage
15+
spec.metadata['changelog_uri'] = spec.homepage
1516

1617
spec.files = Dir.chdir(File.expand_path(__dir__)) do
17-
Dir["{app,config,db,lib}/**/*", "MIT-LICENSE", "Rakefile", "README.md"]
18+
Dir['{app,config,db,lib}/**/*', 'MIT-LICENSE', 'Rakefile', 'README.md']
1819
end
1920

20-
spec.add_dependency "rails", ">= 7.0.4"
21+
spec.add_dependency 'rails', '>= 7.0.4.2'
2122
end

lib/importmap_mocha-rails.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
require "importmap_mocha/version"
2-
require "importmap_mocha/engine"
1+
require 'importmap_mocha/version'
2+
require 'importmap_mocha/engine'
33

44
module ImportmapMocha
55
end

lib/importmap_mocha/engine.rb

Lines changed: 11 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,16 @@
1+
# frozen_string_literal: true
2+
13
module ImportmapMocha
24
class Engine < ::Rails::Engine
3-
45
config.before_initialize do
56
Rails.application.config.importmap_mocha_path = []
6-
['test', 'spec'].each do |d|
7+
%w[test spec].each do |d|
78
path = Rails.root.join(d, 'javascripts')
89
Rails.application.config.importmap_mocha_path << path if path.exist?
910
end
1011
end
1112

12-
initializer "importmap_mocha.assets" do
13+
initializer 'importmap_mocha.assets' do
1314
if Rails.application.config.respond_to?(:assets)
1415
Rails.application.config.assets.paths << Engine.root.join('app/assets/javascripts')
1516
Rails.application.config.assets.paths << Engine.root.join('app/assets/stylesheets')
@@ -19,29 +20,25 @@ class Engine < ::Rails::Engine
1920
end
2021
end
2122

22-
PRECOMPILE_ASSETS = %w( importmap_mocha.js chai.js mocha.js mocha.css )
23+
PRECOMPILE_ASSETS = %w[importmap_mocha.js chai.js mocha.js mocha.css].freeze
2324

24-
initializer "turbo.assets" do
25-
if Rails.application.config.respond_to?(:assets)
26-
Rails.application.config.assets.precompile += PRECOMPILE_ASSETS
27-
end
25+
initializer 'turbo.assets' do
26+
Rails.application.config.assets.precompile += PRECOMPILE_ASSETS if Rails.application.config.respond_to?(:assets)
2827
end
2928

30-
initializer "importmap_mocha.importmap", before: "importmap" do |app|
31-
if Rails.application.respond_to?(:importmap)
32-
app.config.importmap.paths << Engine.root.join("config/importmap.rb")
33-
end
29+
initializer 'importmap_mocha.importmap', before: 'importmap' do |app|
30+
app.config.importmap.paths << Engine.root.join('config/importmap.rb') if Rails.application.respond_to?(:importmap)
3431
end
3532

36-
initializer "importmap_mocha.routes" do
33+
initializer 'importmap_mocha.routes' do
3734
Rails.application.routes.prepend do
3835
scope module: 'importmap_mocha' do
3936
get '/rails/info/mocha' => 'test#index'
4037
end
4138
end
4239
end
4340

44-
initializer "importmap_mocha.config" do
41+
initializer 'importmap_mocha.config' do
4542
unless Rails.application.config.respond_to?(:importmap_mocha_style)
4643
Rails.application.config.importmap_mocha_style = 'bdd'
4744
end

0 commit comments

Comments
 (0)